Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639246
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub() |
| Date | 2017-05-11 10:40 +0200 |
| Message-ID | <tFRNE-40O-19@gated-at.bofh.it> (permalink) |
| References | <tFRND-40O-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, May 11, 2017 at 10:21:46AM +0200, Lars Ellenberg wrote:
> Regression fix for 4.11, which totally broke DRBD
>
> When killing kref_sub(), the unconditional additional kref_get()
> was not properly paired with the necessary kref_put(), causing
> a leak of struct drbd_requests (~ 224 Bytes) per submitted bio,
> and breaking DRBD in general, as the destructor of those "drbd_requests"
> does more than just the mempoll_free().
>
> Fixes: bdfafc4ffdd2 ("locking/atomic, kref: Kill kref_sub()")
> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Dang, sorry about that. Thanks for fixing it.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub() Lars Ellenberg <lars.ellenberg@linbit.com> - 2017-05-11 10:40 +0200 Re: [PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub() Peter Zijlstra <peterz@infradead.org> - 2017-05-11 10:40 +0200 Re: [PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub() Jens Axboe <axboe@kernel.dk> - 2017-05-11 18:10 +0200
csiph-web