Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1639245

Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

Show all headers | View raw

Hi Alan,

On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote:
> > +	if (!(tmp_termios.c_cflag & CRTSCTS)) {
> > +		tmp_termios.c_cflag |= CRTSCTS;
> > +		ret = tty_set_termios(tty, &tmp_termios);
> > +		if (ret)
> > +			pr_warn("speakup: Failed to set hardware flow control\n");
> 
> You should check the tty c_cflag after the call rather than rely on an
> error code. Strictly speaking tty_set_termios should error if no tty bits
> are changed by the request but it never has on Linux. Instead check the
> tty gave you the result you wanted.
Thanks. I will replace the check for return value with check for c_cflag.

May be we should fix this in tty_set_termios?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch 0/1] staging: speakup: flush tty buffers and ensure hardware flow control okash.khawaja@gmail.com - 2017-05-09 14:50 +0200
  [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control okash.khawaja@gmail.com - 2017-05-09 14:50 +0200
    Re: [patch 1/1] staging: speakup: flush tty buffers and ensure  hardware flow control Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-10 21:50 +0200
      Re: [patch 1/1] staging: speakup: flush tty buffers and ensure  hardware flow control Okash Khawaja <okash.khawaja@gmail.com> - 2017-05-11 10:40 +0200
        Re: [patch 1/1] staging: speakup: flush tty buffers and ensure  hardware flow control Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-11 15:40 +0200

csiph-web