Re: [PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub()

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub()
Date	2017-05-11 18:10 +0200
Message-ID	<tFYP9-7g-43@gated-at.bofh.it> (permalink)
References	<tFRND-40O-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/11/2017 02:21 AM, Lars Ellenberg wrote:
> Regression fix for 4.11, which totally broke DRBD
> 
> When killing kref_sub(), the unconditional additional kref_get()
> was not properly paired with the necessary kref_put(), causing
> a leak of struct drbd_requests (~ 224 Bytes) per submitted bio,
> and breaking DRBD in general, as the destructor of those "drbd_requests"
> does more than just the mempoll_free().

Ugh... Applied for this series. I'll mark it stable for 4.11.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub() Lars Ellenberg <lars.ellenberg@linbit.com> - 2017-05-11 10:40 +0200
  Re: [PATCH] drbd: fix request leak introduced by locking/atomic,  kref: Kill kref_sub() Peter Zijlstra <peterz@infradead.org> - 2017-05-11 10:40 +0200
  Re: [PATCH] drbd: fix request leak introduced by locking/atomic,  kref: Kill kref_sub() Jens Axboe <axboe@kernel.dk> - 2017-05-11 18:10 +0200

csiph-web