Re: [PATCH] key: Convert big_key payload.data to struct

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] key: Convert big_key payload.data to struct
Date	2017-05-09 10:20 +0200
Message-ID	<tF8xb-7xS-7@gated-at.bofh.it> (permalink)
References	<tEZke-1sP-7@gated-at.bofh.it> <tEYHw-Wn-19@gated-at.bofh.it> <tEZ0S-1js-11@gated-at.bofh.it> <tEZke-1sP-7@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Kees Cook <keescook@chromium.org> wrote:

> This doesn't protect you against changes in struct path size,
> though... the existing code (and this proposal) will break if that
> ever happens...

True - in which case you should kmalloc() it as Eric suggests.

> What's the problem with defining the types at the top level? That
> seems like a nice place to see them all at once.

It means adding a bunch of dependencies to linux/key.h and union key_payload.

Have you considered why we don't just put all the definitions for all the
filesystems in linux/fs.h?  By this logic it would seem like a nice place to
see them all at once.

David

Thread

[PATCH] key: Convert big_key payload.data to struct Kees Cook <keescook@chromium.org> - 2017-05-08 23:50 +0200
  Re: [PATCH] key: Convert big_key payload.data to struct David Howells <dhowells@redhat.com> - 2017-05-09 00:10 +0200
    Re: [PATCH] key: Convert big_key payload.data to struct Kees Cook <keescook@chromium.org> - 2017-05-09 00:30 +0200
      Re: [PATCH] key: Convert big_key payload.data to struct David Howells <dhowells@redhat.com> - 2017-05-09 10:20 +0200
        Re: [PATCH] key: Convert big_key payload.data to struct Kees Cook <keescook@chromium.org> - 2017-05-09 18:20 +0200
    Re: [PATCH] key: Convert big_key payload.data to struct Eric Biggers <ebiggers3@gmail.com> - 2017-05-09 00:30 +0200
      Re: [PATCH] key: Convert big_key payload.data to struct David Howells <dhowells@redhat.com> - 2017-05-09 09:30 +0200
        Re: [PATCH] key: Convert big_key payload.data to struct Eric Biggers <ebiggers3@gmail.com> - 2017-05-09 23:50 +0200

csiph-web