Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry
Date	2017-04-30 15:00 +0200
Message-ID	<tBWCd-3lS-13@gated-at.bofh.it> (permalink)
References	(4 earlier) <txwdk-3uy-17@gated-at.bofh.it> <txwwG-3Q5-15@gated-at.bofh.it> <txxsJ-4oB-13@gated-at.bofh.it> <tBuFX-39X-7@gated-at.bofh.it> <tBuFX-39X-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Apr 29, 2017 at 10:05 AM, Martin Kaiser <martin@kaiser.cx> wrote:
> Thus wrote Andy Shevchenko (andy.shevchenko@gmail.com):
>> On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser <martin@kaiser.cx> wrote:

>> Aren't 0 and 0444 different by meaning?
>
> my undestanding is that proc_create() calls proc_create_data(), where
>
>    if ((mode & S_IALLUGO) == 0)
>       mode |= S_IRUGO;
>
> sets mode to 0444 when it was 0.

Ah, okay. Fair enough.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc  entry Martin Kaiser <martin@kaiser.cx> - 2017-04-29 09:10 +0200
  Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-30 15:00 +0200

csiph-web