Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry

From	Martin Kaiser <martin@kaiser.cx>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry
Date	2017-04-29 09:10 +0200
Message-ID	<tBuFX-39X-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <txt5M-1FB-3@gated-at.bofh.it> <txwdk-3uy-17@gated-at.bofh.it> <txwwG-3Q5-15@gated-at.bofh.it> <txxsJ-4oB-13@gated-at.bofh.it> <tBuFX-39X-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Andy,

Thus wrote Andy Shevchenko (andy.shevchenko@gmail.com):

> On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser <martin@kaiser.cx> wrote:

> > checkpatch is asking for a 4 digit octal number. And at least for me,
> > 0444 makes it clearer what the permissions actually are. Yes, somewhere
> > in the code, I can dig up that 0 is changed to 0444...

> Aren't 0 and 0444 different by meaning?

my undestanding is that proc_create() calls proc_create_data(), where

   if ((mode & S_IALLUGO) == 0)
      mode |= S_IRUGO;

sets mode to 0444 when it was 0.

Best regards,
Martin

(added the lkml back to Cc, I removed it by accident in an earlier mail)

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc  entry Martin Kaiser <martin@kaiser.cx> - 2017-04-29 09:10 +0200
  Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-30 15:00 +0200

csiph-web