Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1633434

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state
Date 2017-04-30 15:00 +0200
Message-ID <tBWCd-3lS-11@gated-at.bofh.it> (permalink)
References <tbVV8-7YF-9@gated-at.bofh.it> <tdClj-aH-19@gated-at.bofh.it> <tBjAR-3oJ-9@gated-at.bofh.it> <tBuwh-2QM-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Apr 29, 2017 at 9:52 AM, Ritesh Raj Sarraf <rrs@debian.org> wrote:
> Hello,
>
> On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote:
>> On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf <rrs@debian.org> wrote:
>>
>> > Any further comment on this patch ? Will this be accepted ?
>> > Please give a N/ACK.
>>
>> Sorry for a long delay, but I can't go with this without clear
>> understanding that there is indeed no other ways available.
>> From what I read in the above link
>
> i am assuming you are referring to the launchpad bug report here.

Correct.

>> the main issue that driver doesn't
>> send SW_TABLET_MODE event through input device.
>
> Well. Yes. That is one part. If SW_TABLET_MODE is done in the driver, much
> better. My patch was simply in line with some of the other drivers (hp-wmi and
> thinkpad_acpi) to get it working for Lenovo Yoga series.

sysfs ABI for drivers that provide input interface is quite strong for
my opinion. It means I'm not totally objecting, but I would accept it
if and only if there is nothing else could be done.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for  touchpad state Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-28 21:20 +0200
  Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface  for touchpad state Ritesh Raj Sarraf <rrs@debian.org> - 2017-04-29 09:00 +0200
    Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for  touchpad state Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-30 15:00 +0200
      Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for  touchpad state Darren Hart <dvhart@infradead.org> - 2017-05-01 18:10 +0200
        Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface  for touchpad state Ritesh Raj Sarraf <rrs@debian.org> - 2017-05-01 20:30 +0200
          Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for  touchpad state Darren Hart <dvhart@infradead.org> - 2017-05-01 21:20 +0200
      Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface  for touchpad state Ritesh Raj Sarraf <rrs@debian.org> - 2017-05-03 16:40 +0200
        Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for  touchpad state Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 16:50 +0200
          Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for  touchpad state Darren Hart <dvhart@infradead.org> - 2017-05-03 18:20 +0200
            Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for  touchpad state Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 01:10 +0200

csiph-web