Re: [PATCH] clocksource: add __ro_after_init to cyclecounter

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clocksource: add __ro_after_init to cyclecounter
Date	2017-02-11 21:40 +0100
Message-ID	<t9MCC-5gO-21@gated-at.bofh.it> (permalink)
References	<t9LwR-4DS-1@gated-at.bofh.it> <t9MCB-5gO-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 11 Feb 2017, Ard Biesheuvel wrote:

> On 11 February 2017 at 19:20, Bhumika Goyal <bhumirks@gmail.com> wrote:
> > The object cyclecounter of type cyclecounter is not getting modified
> > after getting initialized by arch_counter_register. Apart from
> > initialization in arch_counter_register it is also passed as an argument
> > to the function timecounter_init but this argument is of type const.
> > Therefore, add __ro_after_init to its declaration.
> >
> 
> I think adding __ro_after_init is fine if this struct is never
> modified after init. But the reference in the commit log to the
> constness of the timecounter_init() argument  makes no sense: that
> only means timecounter_init() will not modify the object, which allows
> pointers to const objects to be passed to it as well. The opposite is
> not true, though: there is no requirement whatsoever that objects
> passed into const pointer arguments should be const themselves.

Indeed.

Thread

[PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-11 20:30 +0100
  Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 19:30 +0100
      Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-12 20:00 +0100
        Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 20:10 +0100
        Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-02-12 21:10 +0100
  Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 19:30 +0100
  [tip:timers/core] clocksource/drivers/arm_arch_timer:: Mark  cyclecounter __ro_after_init tip-bot for Bhumika Goyal <tipbot@zytor.com> - 2017-02-12 20:30 +0100

csiph-web