Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579259

Re: [PATCH] clocksource: add __ro_after_init to cyclecounter

Show all headers | View raw

On Sun, Feb 12, 2017 at 2:05 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sun, 12 Feb 2017, Bhumika Goyal wrote:
>
> Please be more careful with your subject line. The prefix for this is
> definitely not 'clocksource'. git log would have told you the proper one:
>
> clocksource/drivers/arm_arch_timer
>
> 'clocksource' is the general subsystem and used for system wide changes or
> core changes, but not for a particular driver.
>

I will be more careful about this in future.

Thanks,
Bhumika

>> The object cyclecounter of type cyclecounter is not getting modified
>> after getting initialized by arch_counter_register. Apart from
>> initialization in arch_counter_register it is also passed as an argument
>> to the function timecounter_init but this argument is of type const.
>> Therefore, add __ro_after_init to its declaration.
>
> Other than that this is fine. I'll fix it up when applying.
>
> Thanks,
>
>         tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-11 20:30 +0100
  Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 19:30 +0100
      Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-12 20:00 +0100
        Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 20:10 +0100
        Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-02-12 21:10 +0100
  Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 19:30 +0100
  [tip:timers/core] clocksource/drivers/arm_arch_timer:: Mark  cyclecounter __ro_after_init tip-bot for Bhumika Goyal <tipbot@zytor.com> - 2017-02-12 20:30 +0100

csiph-web