Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579258

Re: [PATCH] clocksource: add __ro_after_init to cyclecounter

Show all headers | View raw

On Sun, Feb 12, 2017 at 2:01 AM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> On 11 February 2017 at 19:20, Bhumika Goyal <bhumirks@gmail.com> wrote:
>> The object cyclecounter of type cyclecounter is not getting modified
>> after getting initialized by arch_counter_register. Apart from
>> initialization in arch_counter_register it is also passed as an argument
>> to the function timecounter_init but this argument is of type const.
>> Therefore, add __ro_after_init to its declaration.
>>
>
> I think adding __ro_after_init is fine if this struct is never
> modified after init. But the reference in the commit log to the
> constness of the timecounter_init() argument  makes no sense: that
> only means timecounter_init() will not modify the object, which allows
> pointers to const objects to be passed to it as well. The opposite is
> not true, though: there is no requirement whatsoever that objects
> passed into const pointer arguments should be const themselves.
>
>

Yes, true. I will change the commit log and send a v2. Thanks for explaining.

Thanks,
Bhumika

>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>> ---
>>  drivers/clocksource/arm_arch_timer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
>> index 4c8c3fb..a10506b 100644
>> --- a/drivers/clocksource/arm_arch_timer.c
>> +++ b/drivers/clocksource/arm_arch_timer.c
>> @@ -580,7 +580,7 @@ static u64 arch_counter_read_cc(const struct cyclecounter *cc)
>>         .flags  = CLOCK_SOURCE_IS_CONTINUOUS,
>>  };
>>
>> -static struct cyclecounter cyclecounter = {
>> +static struct cyclecounter cyclecounter __ro_after_init = {
>>         .read   = arch_counter_read_cc,
>>         .mask   = CLOCKSOURCE_MASK(56),
>>  };
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-11 20:30 +0100
  Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 19:30 +0100
      Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-12 20:00 +0100
        Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 20:10 +0100
        Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-02-12 21:10 +0100
  Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 21:40 +0100
    Re: [PATCH] clocksource: add __ro_after_init to cyclecounter Bhumika Goyal <bhumirks@gmail.com> - 2017-02-12 19:30 +0100
  [tip:timers/core] clocksource/drivers/arm_arch_timer:: Mark  cyclecounter __ro_after_init tip-bot for Bhumika Goyal <tipbot@zytor.com> - 2017-02-12 20:30 +0100

csiph-web