Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506289

Re: [PATCH] clk: fix link error for rcar-gen2

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: fix link error for rcar-gen2
Date 2016-10-21 23:10 +0200
Message-ID <suPeG-2CB-9@gated-at.bofh.it> (permalink)
References <suKf0-7AT-23@gated-at.bofh.it> <suMqt-ND-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Friday, October 21, 2016 8:01:49 PM CEST Geert Uytterhoeven wrote:
> > diff --git a/drivers/clk/renesas/Makefile b/drivers/clk/renesas/Makefile
> > index 90dd0db7d9c6..762d122eddec 100644
> > --- a/drivers/clk/renesas/Makefile
> > +++ b/drivers/clk/renesas/Makefile
> > @@ -4,11 +4,7 @@ obj-$(CONFIG_ARCH_R8A73A4)             += clk-r8a73a4.o clk-div6.o
> >  obj-$(CONFIG_ARCH_R8A7740)             += clk-r8a7740.o clk-div6.o
> >  obj-$(CONFIG_ARCH_R8A7778)             += clk-r8a7778.o
> >  obj-$(CONFIG_ARCH_R8A7779)             += clk-r8a7779.o
> > -obj-$(CONFIG_ARCH_R8A7790)             += clk-rcar-gen2.o clk-div6.o
> > -obj-$(CONFIG_ARCH_R8A7791)             += clk-rcar-gen2.o clk-div6.o
> > -obj-$(CONFIG_ARCH_R8A7792)             += clk-rcar-gen2.o clk-div6.o
> > -obj-$(CONFIG_ARCH_R8A7793)             += clk-rcar-gen2.o clk-div6.o
> > -obj-$(CONFIG_ARCH_R8A7794)             += clk-rcar-gen2.o clk-div6.o
> > +obj-$(CONFIG_ARCH_RCAR_GEN2)           += clk-rcar-gen2.o clk-div6.o
> >  obj-$(CONFIG_ARCH_R8A7795)             += r8a7795-cpg-mssr.o rcar-gen3-cpg.o
> >  obj-$(CONFIG_ARCH_R8A7796)             += r8a7796-cpg-mssr.o rcar-gen3-cpg.o
> >  obj-$(CONFIG_ARCH_SH73A0)              += clk-sh73a0.o clk-div6.o
> 
> Please don't fix it this way, as it will make it _harder_ to convert the R-Car
> Gen2 SoCs to the modern CPG/MSSR driver later.
> 

Ok, I see. How about just adding another line for r8a7743 and
dropping that again after the timer_init has been converted?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: fix link error for rcar-gen2 Arnd Bergmann <arnd@arndb.de> - 2016-10-21 17:50 +0200
  Re: [PATCH] clk: fix link error for rcar-gen2 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-10-21 18:50 +0200
  Re: [PATCH] clk: fix link error for rcar-gen2 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-21 20:10 +0200
    Re: [PATCH] clk: fix link error for rcar-gen2 Arnd Bergmann <arnd@arndb.de> - 2016-10-21 23:10 +0200
      Re: [PATCH] clk: fix link error for rcar-gen2 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-25 10:40 +0200

csiph-web