Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1506146

Re: [PATCH] clk: fix link error for rcar-gen2

From Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: fix link error for rcar-gen2
Date 2016-10-21 18:50 +0200
Message-ID <suLb4-8f6-35@gated-at.bofh.it> (permalink)
References <suKf0-7AT-23@gated-at.bofh.it>
Organization Cogent Embedded

Show all headers | View raw


Hello.

On 10/21/2016 06:47 PM, Arnd Bergmann wrote:

> The addition of one more rcar-gen2 based SoC caused a build error (again)
> in my randconfig builds:
>
> arch/arm/mach-shmobile/setup-rcar-gen2.o: In function `rcar_gen2_timer_init':
> setup-rcar-gen2.c:(.init.text+0x200): undefined reference to `rcar_gen2_clocks_init'

    OK, seeing how you got this -- I should have tested the kernel build with 
only R8A7743 enabled... sorry about that. :-<
    I probably shouldn't have used rcar_gen2_timer_init() in the 1st place...

> I think this has happened twice in the past. Instead of adding each SoC
> one at a time, this changes the existing list to always build the
> rcar-gen2 related clk files whenever the generic symbol is selected.

    The problem is we're not going to use this driver on RZ/G SoCs... The 
newer rcar2-cpg-mssr.c will be used instead -- I submitted the patches for 
that before ELC-E...

> Fixes: 1254f607fc3d ("ARM: shmobile: r8a7743: basic SoC support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[...]

MBR, Sergei

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] clk: fix link error for rcar-gen2 Arnd Bergmann <arnd@arndb.de> - 2016-10-21 17:50 +0200
  Re: [PATCH] clk: fix link error for rcar-gen2 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-10-21 18:50 +0200
  Re: [PATCH] clk: fix link error for rcar-gen2 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-21 20:10 +0200
    Re: [PATCH] clk: fix link error for rcar-gen2 Arnd Bergmann <arnd@arndb.de> - 2016-10-21 23:10 +0200
      Re: [PATCH] clk: fix link error for rcar-gen2 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-25 10:40 +0200

csiph-web