Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace
Date	2016-10-11 23:20 +0200
Message-ID	<srcCS-3n1-15@gated-at.bofh.it> (permalink)
References	<srbQt-2QB-7@gated-at.bofh.it> <srbQu-2QB-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 11 Oct 2016 15:26:18 -0500
Zach Brown <zach.brown@ni.com> wrote:

> Adding led support for phy causes namespace conflicts for some
> phy drivers.
> 
> The marvel skge driver declared an enum for representing the states of
> Link LED Register. The enum contained constant LED_OFF which conflicted
> with declartation found in linux/leds.h.
> LED_OFF changed to LED_REG_OFF
> Also changed LED_ON to LED_REG_ON to avoid possible future conflict and
> for consistency.
> 
> Signed-off-by: Zach Brown <zach.brown@ni.com>

Sure, that's fine but not sure why skge would be including linux/leds.h
anyway.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] Add support for led triggers on phy link state change Zach Brown <zach.brown@ni.com> - 2016-10-11 22:30 +0200
  [PATCH v4 2/3] net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link Zach Brown <zach.brown@ni.com> - 2016-10-11 22:30 +0200
  [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace Zach Brown <zach.brown@ni.com> - 2016-10-11 22:30 +0200
    Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge  driver to avoid conflicts with leds namespace Stephen Hemminger <stephen@networkplumber.org> - 2016-10-11 23:20 +0200

csiph-web