Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace
Date	Tue, 11 Oct 2016 23:20:02 +0200
Message-ID	<srcCS-3n1-15@gated-at.bofh.it> (permalink)
References	<srbQt-2QB-7@gated-at.bofh.it> <srbQu-2QB-19@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZVLqTrjq0/BWUEF/7yzx5jBYX+AI4Sw0sn4JK6ukRfk=; b=rCj6FvhvzldL5RPeECEZTYeysIrtD6mcyv3pPHdRnFkCdneEcsh3LOxzD4txKt3f/D ECwgjM3u0uhVVWrW8Al/j0yLHu2WYEOeit2MfMXFG/WUDcBPNyokb2L3WKbRsI+BTAUP 6JUkQ1P9JjxcTghj0IpsTpU/rMc9ayEas4QECN7aO20TCzbHNTklM513aOZ7dceHG48j 1PSRk5rK4H4b6K67yt+5Olj1EH2nRfupU095NhmddL368vj5WBvnfUFV1OceyZBo4Lyi tJeNkA6KwgFvpwz2owe/WO7aG56wiMs3BrQU9FQc1ajgMrtXCyYmjc//3/8WqLZCWuop vWag==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZVLqTrjq0/BWUEF/7yzx5jBYX+AI4Sw0sn4JK6ukRfk=; b=V4G817LILHW0P8n07IG7da4fvZKv0ILr6UeGm5yw6OxRvfBKJrX50MrfkEv28jwDgZ GzNDcp0nSw/MTppv7qUhSkX4eqlHbLHC9PpjF5sMt/+kVh6g5hWvgVXkv0J9Dl12jijK zC0Ve4h4vQxufR8dNu/g5fIeOQp6Fa4mWjJfQ3O9dhJvYuz5QGdU9LL8en9xf3pWEUwO 5pE5C6hZWth9q8jRtCMfxKTEyH7fgxXAtm4iLyryMb+trNZEeVAq2Trp5NyrcgPGkAkp AEtVlF3/Lx1S3km4v7NPsJtN/axfhxV2Ebn7eZYx21OqxDPGWWtPXgyAZBHtWU1qSqZi pHRQ==
X-Gm-Message-State	AA6/9Rn3mJWwzuTc4aCiiekSQx1bqYa6KY2ykaUI/gmOwufYM82TGaU4wvdes1NNSnc/QQ==
X-Received	by 10.66.187.136 with SMTP id fs8mr10084712pac.181.1476220433139; Tue, 11 Oct 2016 14:13:53 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	f.fainelli@gmail.com, mlindner@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, rpurdie@rpsys.net, j.anaszewski@samsung.com, linux-leds@vger.kernel.org, andrew@lunn.ch
X-Original-Date	Tue, 11 Oct 2016 14:14:07 -0700
X-Original-Message-ID	<20161011141407.3b233e83@xeon-e3>
X-Original-References	<1476217580-21229-1-git-send-email-zach.brown@ni.com> <1476217580-21229-2-git-send-email-zach.brown@ni.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1499211

Show key headers only | View raw

On Tue, 11 Oct 2016 15:26:18 -0500
Zach Brown <zach.brown@ni.com> wrote:

> Adding led support for phy causes namespace conflicts for some
> phy drivers.
> 
> The marvel skge driver declared an enum for representing the states of
> Link LED Register. The enum contained constant LED_OFF which conflicted
> with declartation found in linux/leds.h.
> LED_OFF changed to LED_REG_OFF
> Also changed LED_ON to LED_REG_ON to avoid possible future conflict and
> for consistency.
> 
> Signed-off-by: Zach Brown <zach.brown@ni.com>

Sure, that's fine but not sure why skge would be including linux/leds.h
anyway.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] Add support for led triggers on phy link state change Zach Brown <zach.brown@ni.com> - 2016-10-11 22:30 +0200
  [PATCH v4 2/3] net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link Zach Brown <zach.brown@ni.com> - 2016-10-11 22:30 +0200
  [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace Zach Brown <zach.brown@ni.com> - 2016-10-11 22:30 +0200
    Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge  driver to avoid conflicts with leds namespace Stephen Hemminger <stephen@networkplumber.org> - 2016-10-11 23:20 +0200

csiph-web