Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO
Date	2016-10-10 10:50 +0200
Message-ID	<sqErw-7rt-29@gated-at.bofh.it> (permalink)
References	<slOrv-2mC-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 27, 2016 at 2:26 AM, Stefan Agner <stefan@agner.ch> wrote:

> +       /* Only change pad configuration if pad is still a GPIO */
> +       if (reg & (0x7 << 20))
> +               return;
> +
> +       /* Clear IBE/OBE/PUE to disable the pin (Hi-Z) */
>         reg &= ~0x7;
>         writel(reg, ipctl->base + pin_reg->mux_reg);

Please #define the magic 7 and 20 above so we see what is going
on if you choose this approach.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 02:30 +0200
  Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 14:20 +0200
    Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 18:50 +0200
      Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 20:20 +0200
        Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 21:50 +0200
          Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 22:30 +0200
          Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-28 04:10 +0200
            Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-28 05:50 +0200
              Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-28 06:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-29 18:40 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-30 04:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-10-10 10:40 +0200
              Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-28 14:10 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-29 08:50 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-29 14:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-30 04:30 +0200
  Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-10-10 10:50 +0200

csiph-web