Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1493164

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO
Date 2016-09-29 08:50 +0200
Message-ID <smDkm-ut-5@gated-at.bofh.it> (permalink)
References (3 earlier) <sm58Z-4tU-9@gated-at.bofh.it> <sm6y5-5bY-7@gated-at.bofh.it> <smctP-CI-7@gated-at.bofh.it> <sme2C-1zP-3@gated-at.bofh.it> <smlQt-6sb-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 28-09-16, 15:07, Vladimir Zapolskiy wrote:
> I would expect that the change below improves the situation, but I didn't
> perform any tests and here the core change is governed by the accepted
> i.MX i2c bus driver specific changes, thus conceptually it may be incorrect:
> 
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index da3a02ef4a31..3a4f59c3c3e6 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -697,9 +697,6 @@ static int i2c_generic_recovery(struct i2c_adapter *adap)
>  	struct i2c_bus_recovery_info *bri = adap->bus_recovery_info;
>  	int i = 0, val = 1, ret = 0;
> -	if (bri->prepare_recovery)
> -		bri->prepare_recovery(adap);
> -
>  	bri->set_scl(adap, val);
>  	ndelay(RECOVERY_NDELAY);
> @@ -725,22 +722,34 @@ static int i2c_generic_recovery(struct i2c_adapter *adap)
>  		ndelay(RECOVERY_NDELAY);
>  	}
> -	if (bri->unprepare_recovery)
> -		bri->unprepare_recovery(adap);
> -
>  	return ret;
>  }
>  int i2c_generic_scl_recovery(struct i2c_adapter *adap)
>  {
> -	return i2c_generic_recovery(adap);
> +	struct i2c_bus_recovery_info *bri = adap->bus_recovery_info;
> +	int ret;
> +
> +	if (bri->prepare_recovery)
> +		bri->prepare_recovery(adap);
> +
> +	ret = i2c_generic_recovery(adap);
> +
> +	if (bri->unprepare_recovery)
> +		bri->unprepare_recovery(adap);
> +
> +	return ret;
>  }
>  EXPORT_SYMBOL_GPL(i2c_generic_scl_recovery);
>  int i2c_generic_gpio_recovery(struct i2c_adapter *adap)
>  {
> +	struct i2c_bus_recovery_info *bri = adap->bus_recovery_info;
>  	int ret;
> +	if (bri->prepare_recovery)
> +		bri->prepare_recovery(adap);
> +
>  	ret = i2c_get_gpios_for_recovery(adap);
>  	if (ret)
>  		return ret;
> @@ -748,6 +757,9 @@ int i2c_generic_gpio_recovery(struct i2c_adapter *adap)
>  	ret = i2c_generic_recovery(adap);
>  	i2c_put_gpios_for_recovery(adap);
> +	if (bri->unprepare_recovery)
> +		bri->unprepare_recovery(adap);
> +
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(i2c_generic_gpio_recovery);

That looks to like a hack made just to make things work on one platform.

I would rather wait for an answer to my query first, which I asked in a separate
email.
 
-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 02:30 +0200
  Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 14:20 +0200
    Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 18:50 +0200
      Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 20:20 +0200
        Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 21:50 +0200
          Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 22:30 +0200
          Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-28 04:10 +0200
            Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-28 05:50 +0200
              Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-28 06:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-29 18:40 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-30 04:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-10-10 10:40 +0200
              Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-28 14:10 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-29 08:50 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-29 14:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-30 04:30 +0200
  Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-10-10 10:50 +0200

csiph-web