Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1492236

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO
Date 2016-09-28 04:10 +0200
Message-ID <smctP-CI-7@gated-at.bofh.it> (permalink)
References <slOrv-2mC-9@gated-at.bofh.it> <slZwB-YB-9@gated-at.bofh.it> <sm3JU-3si-15@gated-at.bofh.it> <sm58Z-4tU-9@gated-at.bofh.it> <sm6y5-5bY-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 27-09-16, 12:34, Stefan Agner wrote:
> Added Viresh Kumar to the discussion, he implemented the I2C recovery
> functions.
> 
> Yes, reordering the pinctrl/gpio_free calls would fix the problem too.
> 
> However, I guess there is no explicit rule to that ("request/free GPIOs
> only when they are muxed as GPIO"), so I think of it that the issue is
> actually in the pinctrl driver.
> 
> On top of that it is not entirely trivial to reorder the calls the way
> i2c_generic_gpio_recovery and i2c_generic_recovery are set up right now.

AFAICT, these routines don't touch the muxing part at all. Perhaps it is done
internally by the GPIO calls. Can you please elaborate the exact change you are
hinting towards here ?

-- 
viresh

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 02:30 +0200
  Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 14:20 +0200
    Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 18:50 +0200
      Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 20:20 +0200
        Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-27 21:50 +0200
          Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-27 22:30 +0200
          Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-28 04:10 +0200
            Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-28 05:50 +0200
              Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-28 06:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Stefan Agner <stefan@agner.ch> - 2016-09-29 18:40 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-30 04:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-10-10 10:40 +0200
              Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-28 14:10 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-29 08:50 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-09-29 14:20 +0200
                Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-30 04:30 +0200
  Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when  freeing GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-10-10 10:50 +0200

csiph-web