Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494957

Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

Show all headers | View raw

On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote:
> This patch fix the following checkpatch.pl warnings in prism2sta.c:
> WARNING: line over 80 characters
[]
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
[]
> @@ -1099,7 +1101,8 @@ static void prism2sta_inf_hostscanresults(struct wlandevice *wlandev,
>  
>  	kfree(hw->scanresults);
>  
> -	hw->scanresults = kmemdup(inf, sizeof(struct hfa384x_InfFrame), GFP_ATOMIC);
> +	hw->scanresults = kmemdup(inf,
> +				  sizeof(struct hfa384x_InfFrame), GFP_ATOMIC);

Perhaps better as

	hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files. Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 11/15] staging: wlang-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 06/15] staging: wlang-ng: do not return -ENOSYS Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 13/15] staging: wlang-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 15/15] staging: wlang-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 12/15] staging: wlang-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 03/15] staging: wlang-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 14/15]  staging: wlang-ng: fix line style warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
    Re: [PATCH 14/15]  staging: wlang-ng: fix line style warnings in  prism2sta.c Joe Perches <joe@perches.com> - 2016-10-03 18:20 +0200
      Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 20:20 +0200
        Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Joe Perches <joe@perches.com> - 2016-10-03 20:20 +0200
          Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-04 06:50 +0200
  [PATCH 09/15] staging: wlang-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 01/15] staging: wlang-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  Re: [PATCH 00/15] staging: wlang-ng: Fix several style issues in  several source files. Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 16:40 +0200
    [PATCH 03/15] staging: wlan-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 09/15] staging: wlan-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 08/15] staging: wlan-ng: fix line style warnings in p80211req.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 15/15] staging: wlan-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 07/15] staging: wlan-ng: fix block comment warnings in p80211req.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 10/15] staging: wlan-ng: fix line style warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 04/15] staging: wlan-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 06/15] staging: wlan-ng: do not return -ENOSYS Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 05/15] staging: wlan-ng: fix block comment warnings in p80211netdev.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 11/15] staging: wlan-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 01/15] staging: wlan-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 13/15] staging: wlan-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 12/15] staging: wlan-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 14/15]  staging: wlan-ng: fix line style warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
      Re: [PATCH 14/15]  staging: wlan-ng: fix line style warnings in  prism2sta.c Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:30 +0200
        Re: [PATCH 14/15] staging: wlan-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:50 +0200
    [PATCH 00/15] staging: wlan-ng: Fix several style issues in several source files. Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200

csiph-web