Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494944

[PATCH 06/15] staging: wlang-ng: do not return -ENOSYS

From Sergio Paracuellos <sergio.paracuellos@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 06/15] staging: wlang-ng: do not return -ENOSYS
Date 2016-10-03 18:10 +0200
Message-ID <sodYu-7ac-41@gated-at.bofh.it> (permalink)
References <sodYu-7ac-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Fixed coding style issue by replacing ENOSYS with EINVAL.

This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/staging/wlan-ng/p80211netdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index fb28d8f..656033a 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -532,7 +532,7 @@ static int p80211netdev_ethtool(struct wlandevice *wlandev,
  *		-ETIME	p80211 cmd timed out (MSD may have its own timers)
  *		-EFAULT memory fault copying msg from user buffer
  *		-ENOMEM unable to allocate kernel msg buffer
- *		-ENOSYS	bad magic, it the cmd really for us?
+ *		-EINVAL	bad magic, it the cmd really for us?
  *		-EintR	sleeping on cmd, awakened by signal, cmd cancelled.
  *
  * Call Context:
@@ -560,7 +560,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
 
 	/* Test the magic, assume ifr is good if it's there */
 	if (req->magic != P80211_IOCTL_MAGIC) {
-		result = -ENOSYS;
+		result = -EINVAL;
 		goto bail;
 	}
 
@@ -568,7 +568,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
 		result = 0;
 		goto bail;
 	} else if (cmd != P80211_IFREQ) {
-		result = -ENOSYS;
+		result = -EINVAL;
 		goto bail;
 	}
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files. Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 11/15] staging: wlang-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 06/15] staging: wlang-ng: do not return -ENOSYS Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 13/15] staging: wlang-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 15/15] staging: wlang-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 12/15] staging: wlang-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 03/15] staging: wlang-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 14/15]  staging: wlang-ng: fix line style warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
    Re: [PATCH 14/15]  staging: wlang-ng: fix line style warnings in  prism2sta.c Joe Perches <joe@perches.com> - 2016-10-03 18:20 +0200
      Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 20:20 +0200
        Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Joe Perches <joe@perches.com> - 2016-10-03 20:20 +0200
          Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-04 06:50 +0200
  [PATCH 09/15] staging: wlang-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 01/15] staging: wlang-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  Re: [PATCH 00/15] staging: wlang-ng: Fix several style issues in  several source files. Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 16:40 +0200
    [PATCH 03/15] staging: wlan-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 09/15] staging: wlan-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 08/15] staging: wlan-ng: fix line style warnings in p80211req.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 15/15] staging: wlan-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 07/15] staging: wlan-ng: fix block comment warnings in p80211req.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 10/15] staging: wlan-ng: fix line style warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 04/15] staging: wlan-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 06/15] staging: wlan-ng: do not return -ENOSYS Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 05/15] staging: wlan-ng: fix block comment warnings in p80211netdev.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 11/15] staging: wlan-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 01/15] staging: wlan-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 13/15] staging: wlan-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 12/15] staging: wlan-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 14/15]  staging: wlan-ng: fix line style warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
      Re: [PATCH 14/15]  staging: wlan-ng: fix line style warnings in  prism2sta.c Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:30 +0200
        Re: [PATCH 14/15] staging: wlan-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:50 +0200
    [PATCH 00/15] staging: wlan-ng: Fix several style issues in several source files. Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200

csiph-web