Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1495198

Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

From Sergio Paracuellos <sergio.paracuellos@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c
Date 2016-10-04 06:50 +0200
Message-ID <sopPY-648-11@gated-at.bofh.it> (permalink)
References <sodYu-7ac-9@gated-at.bofh.it> <sodYv-7ac-49@gated-at.bofh.it> <soe8a-7gD-7@gated-at.bofh.it> <sog0h-8nQ-1@gated-at.bofh.it> <sog0h-8nQ-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

El 2016年10月03日 a las 20:18, Joe Perches escribió:
> On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote:
>> El 2016年10月03日 a las 18:16, Joe Perches escribió:
>>> Perhaps better as	hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);
>> I agree. But because all the code is full of sizeof(struct xxx) I though
>> it would be bettter to follow the actual style and not change only one...
>> I don't have any problem in fix this patch and resend it. What should I do?
>
> I suggest not fixing this patch.
>
> Maybe just send another patch changing all the applicable
> sizeof(struct <foo>) uses to sizeof(*var) with the appropriate
> line wrapping.
>

Ok, I think that it would be better too. Let's do that.

Thanks,
	Sergio Paracuellos

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files. Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 11/15] staging: wlang-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 06/15] staging: wlang-ng: do not return -ENOSYS Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 13/15] staging: wlang-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 15/15] staging: wlang-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 12/15] staging: wlang-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 03/15] staging: wlang-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 14/15]  staging: wlang-ng: fix line style warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
    Re: [PATCH 14/15]  staging: wlang-ng: fix line style warnings in  prism2sta.c Joe Perches <joe@perches.com> - 2016-10-03 18:20 +0200
      Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 20:20 +0200
        Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Joe Perches <joe@perches.com> - 2016-10-03 20:20 +0200
          Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-04 06:50 +0200
  [PATCH 09/15] staging: wlang-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  [PATCH 01/15] staging: wlang-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-03 18:10 +0200
  Re: [PATCH 00/15] staging: wlang-ng: Fix several style issues in  several source files. Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 16:40 +0200
    [PATCH 03/15] staging: wlan-ng: fix block comment warnings in p80211conv.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 09/15] staging: wlan-ng: fix block comment warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 08/15] staging: wlan-ng: fix line style warnings in p80211req.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 15/15] staging: wlan-ng: fix block comment warnings in prism2fw.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 07/15] staging: wlan-ng: fix block comment warnings in p80211req.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 10/15] staging: wlan-ng: fix line style warnings in p80211wep.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 04/15] staging: wlan-ng: fix line style warnings in p80211netdev.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 06/15] staging: wlan-ng: do not return -ENOSYS Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 05/15] staging: wlan-ng: fix block comment warnings in p80211netdev.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 11/15] staging: wlan-ng: fix block comment warnings in prism2mgmt.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 01/15] staging: wlan-ng: fix line style warnings in hfa384x_usb.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 13/15] staging: wlan-ng: fix block comment warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 12/15] staging: wlan-ng: fix block comment warnings in prism2mib.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
    [PATCH 14/15]  staging: wlan-ng: fix line style warnings in prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200
      Re: [PATCH 14/15]  staging: wlan-ng: fix line style warnings in  prism2sta.c Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 17:30 +0200
        Re: [PATCH 14/15] staging: wlan-ng: fix line style warnings in  prism2sta.c Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:50 +0200
    [PATCH 00/15] staging: wlan-ng: Fix several style issues in several source files. Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-10-09 17:20 +0200

csiph-web