Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484282

Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API

Show all headers | View raw

On 15-09-16, 15:47, Mark Brown wrote:
> On Thu, Sep 15, 2016 at 04:47:01PM +0530, Viresh Kumar wrote:
> 
> > Fix the kernel warnings and crashes by moving away from managed
> > regulator bulk get API by using regulator_bulk_get() and explicitly
> > calling regulator_put() for all the supplies in exit paths.
> 
> Moving away from regulator bulk get to regulator bulk get?

Moving away from "managed" regulator bulk get to regulator bulk get?
Isn't this how we call the devm_* APIs as?

> > -	ret = devm_regulator_bulk_get(wm8994->dev, wm8994->num_supplies,
> > +	ret = regulator_bulk_get(wm8994->dev, wm8994->num_supplies,
> >  				 wm8994->supplies);
> 
> > +err_regulator_put:
> > +	for (i = wm8994->num_supplies - 1; i >= 0; i--)
> > +		regulator_put(wm8994->supplies[i].consumer);
> 
> Why are you unwinding regulator_bulk_get() with an open coded
> regulator_bulk_put()?

Because there is no regulator_bulk_put(). Should I add it?

> Also please think hard before including complete backtraces in upstream
> reports, they are very large and contain almost no useful information
> relative to their size so often obscure the relevant content in your
> message. If part of the backtrace is usefully illustrative then it's
> usually better to pull out the relevant sections.

Sure, will add only relevant bits in the next version.

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mfd: wm8994-core: disable regulators before removing them Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 13:20 +0200
  [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 13:20 +0200
    Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk  get API Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-09-15 14:40 +0200
    Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk  get API Mark Brown <broonie@kernel.org> - 2016-09-15 16:50 +0200
      Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk  get API Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 17:10 +0200
        Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk  get API Mark Brown <broonie@kernel.org> - 2016-09-15 17:50 +0200
  Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing  them Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-09-15 14:40 +0200

csiph-web