Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1483997
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them |
| Date | 2016-09-15 13:20 +0200 |
| Message-ID | <shCRX-6hp-9@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The order in which resources were freed in wm8994_device_exit() isn't
correct. The regulators are removed before they are disabled.
Fix it by reordering code a bit, which makes it exact opposite of
wm8994_device_init() as well.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/mfd/wm8994-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
index 7eec619a6023..1e644aa53a2d 100644
--- a/drivers/mfd/wm8994-core.c
+++ b/drivers/mfd/wm8994-core.c
@@ -604,10 +604,10 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq)
static void wm8994_device_exit(struct wm8994 *wm8994)
{
pm_runtime_disable(wm8994->dev);
- mfd_remove_devices(wm8994->dev);
wm8994_irq_exit(wm8994);
regulator_bulk_disable(wm8994->num_supplies,
wm8994->supplies);
+ mfd_remove_devices(wm8994->dev);
}
static const struct of_device_id wm8994_of_match[] = {
--
2.7.1.410.g6faf27b
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/2] mfd: wm8994-core: disable regulators before removing them Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 13:20 +0200
[PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 13:20 +0200
Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-09-15 14:40 +0200
Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Mark Brown <broonie@kernel.org> - 2016-09-15 16:50 +0200
Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 17:10 +0200
Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Mark Brown <broonie@kernel.org> - 2016-09-15 17:50 +0200
Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-09-15 14:40 +0200
csiph-web