Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them

From	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them
Date	2016-09-15 14:40 +0200
Message-ID	<shE7o-72q-29@gated-at.bofh.it> (permalink)
References	<shCRX-6hp-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 15, 2016 at 04:47:00PM +0530, Viresh Kumar wrote:
> The order in which resources were freed in wm8994_device_exit() isn't
> correct. The regulators are removed before they are disabled.
> 
> Fix it by reordering code a bit, which makes it exact opposite of
> wm8994_device_init() as well.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mfd: wm8994-core: disable regulators before removing them Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 13:20 +0200
  [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 13:20 +0200
    Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk  get API Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-09-15 14:40 +0200
    Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk  get API Mark Brown <broonie@kernel.org> - 2016-09-15 16:50 +0200
      Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk  get API Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-15 17:10 +0200
        Re: [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk  get API Mark Brown <broonie@kernel.org> - 2016-09-15 17:50 +0200
  Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing  them Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-09-15 14:40 +0200

csiph-web