Re: [PATCH 01/11] perf, tools: Factor out scale conversion code

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/11] perf, tools: Factor out scale conversion code
Date	2017-01-12 19:20 +0100
Message-ID	<sYS8G-7eZ-11@gated-at.bofh.it> (permalink)
References	<sVySR-85Q-27@gated-at.bofh.it> <sVz2x-8cw-9@gated-at.bofh.it> <sXqRb-1KB-17@gated-at.bofh.it> <sYNLH-4wW-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Thu, Jan 12, 2017 at 10:31:57AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sun, Jan 08, 2017 at 07:57:53PM +0100, Jiri Olsa escreveu:
> > On Tue, Jan 03, 2017 at 07:08:23AM -0800, Andi Kleen wrote:
> > 
> > SNIP
> > 
> > > -		goto error;
> > > -
> > > -	if (scale[sret - 1] == '\n')
> > > -		scale[sret - 1] = '\0';
> > > -	else
> > > -		scale[sret] = '\0';
> > > +	int ret = 0;
> > >  
> > >  	/*
> > >  	 * save current locale
> > > @@ -133,8 +111,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char *
> > >  	 */
> > >  	lc = strdup(lc);
> > >  	if (!lc) {
> > > -		ret = -ENOMEM;
> > > -		goto error;
> > > +		ret = -1;
> > > +		goto out;
> > 
> > not sure why you changed the -ENOMEM to -1 ;-) but it's ok anyway
> 
> These unrelated things are just that, noise, I'll ditch it to reduce
> patch size while not introducing any functional change.

But then this return is not even being looked at anywhere :-\
  
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> 
> Will keep your ack tho :-)
> 
> - Arnaldo
>  
> > thanks,
> > jirka

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Jiri Olsa <jolsa@redhat.com> - 2017-01-08 20:00 +0100
  Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-12 14:40 +0100
    Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-12 19:20 +0100

csiph-web