Re: [PATCH 01/11] perf, tools: Factor out scale conversion code

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/11] perf, tools: Factor out scale conversion code
Date	2017-01-08 20:00 +0100
Message-ID	<sXqRb-1KB-17@gated-at.bofh.it> (permalink)
References	<sVySR-85Q-27@gated-at.bofh.it> <sVz2x-8cw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 03, 2017 at 07:08:23AM -0800, Andi Kleen wrote:

SNIP

> -		goto error;
> -
> -	if (scale[sret - 1] == '\n')
> -		scale[sret - 1] = '\0';
> -	else
> -		scale[sret] = '\0';
> +	int ret = 0;
>  
>  	/*
>  	 * save current locale
> @@ -133,8 +111,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char *
>  	 */
>  	lc = strdup(lc);
>  	if (!lc) {
> -		ret = -ENOMEM;
> -		goto error;
> +		ret = -1;
> +		goto out;

not sure why you changed the -ENOMEM to -1 ;-) but it's ok anyway

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Jiri Olsa <jolsa@redhat.com> - 2017-01-08 20:00 +0100
  Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-12 14:40 +0100
    Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-12 19:20 +0100

csiph-web