Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1553923 > unrolled thread
| Started by | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| First post | 2017-01-08 20:00 +0100 |
| Last post | 2017-01-12 19:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Jiri Olsa <jolsa@redhat.com> - 2017-01-08 20:00 +0100
Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-12 14:40 +0100
Re: [PATCH 01/11] perf, tools: Factor out scale conversion code Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-12 19:20 +0100
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2017-01-08 20:00 +0100 |
| Subject | Re: [PATCH 01/11] perf, tools: Factor out scale conversion code |
| Message-ID | <sXqRb-1KB-17@gated-at.bofh.it> |
On Tue, Jan 03, 2017 at 07:08:23AM -0800, Andi Kleen wrote:
SNIP
> - goto error;
> -
> - if (scale[sret - 1] == '\n')
> - scale[sret - 1] = '\0';
> - else
> - scale[sret] = '\0';
> + int ret = 0;
>
> /*
> * save current locale
> @@ -133,8 +111,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char *
> */
> lc = strdup(lc);
> if (!lc) {
> - ret = -ENOMEM;
> - goto error;
> + ret = -1;
> + goto out;
not sure why you changed the -ENOMEM to -1 ;-) but it's ok anyway
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
[toc] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2017-01-12 14:40 +0100 |
| Message-ID | <sYNLH-4wW-1@gated-at.bofh.it> |
| In reply to | #1553923 |
Em Sun, Jan 08, 2017 at 07:57:53PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 03, 2017 at 07:08:23AM -0800, Andi Kleen wrote:
>
> SNIP
>
> > - goto error;
> > -
> > - if (scale[sret - 1] == '\n')
> > - scale[sret - 1] = '\0';
> > - else
> > - scale[sret] = '\0';
> > + int ret = 0;
> >
> > /*
> > * save current locale
> > @@ -133,8 +111,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char *
> > */
> > lc = strdup(lc);
> > if (!lc) {
> > - ret = -ENOMEM;
> > - goto error;
> > + ret = -1;
> > + goto out;
>
> not sure why you changed the -ENOMEM to -1 ;-) but it's ok anyway
These unrelated things are just that, noise, I'll ditch it to reduce
patch size while not introducing any functional change.
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Will keep your ack tho :-)
- Arnaldo
> thanks,
> jirka
[toc] | [prev] | [next] | [standalone]
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Date | 2017-01-12 19:20 +0100 |
| Message-ID | <sYS8G-7eZ-11@gated-at.bofh.it> |
| In reply to | #1557452 |
Em Thu, Jan 12, 2017 at 10:31:57AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sun, Jan 08, 2017 at 07:57:53PM +0100, Jiri Olsa escreveu:
> > On Tue, Jan 03, 2017 at 07:08:23AM -0800, Andi Kleen wrote:
> >
> > SNIP
> >
> > > - goto error;
> > > -
> > > - if (scale[sret - 1] == '\n')
> > > - scale[sret - 1] = '\0';
> > > - else
> > > - scale[sret] = '\0';
> > > + int ret = 0;
> > >
> > > /*
> > > * save current locale
> > > @@ -133,8 +111,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char *
> > > */
> > > lc = strdup(lc);
> > > if (!lc) {
> > > - ret = -ENOMEM;
> > > - goto error;
> > > + ret = -1;
> > > + goto out;
> >
> > not sure why you changed the -ENOMEM to -1 ;-) but it's ok anyway
>
> These unrelated things are just that, noise, I'll ditch it to reduce
> patch size while not introducing any functional change.
But then this return is not even being looked at anywhere :-\
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Will keep your ack tho :-)
>
> - Arnaldo
>
> > thanks,
> > jirka
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web