Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1538131
| From | Finn Thain <fthain@telegraphics.com.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 02/22] m68k/mac: macints - Modernize printing of kernel messages |
| Date | 2016-12-07 23:50 +0100 |
| Message-ID | <sLTcd-6aD-7@gated-at.bofh.it> (permalink) |
| References | <sLMaJ-1Ll-5@gated-at.bofh.it> <sLMaK-1Ll-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
> - Introduce helpers for printing debug messages, incl. dummies for
> validating format strings when debugging is disabled,
> - Convert from printk() to pr_*(),
> - Add missing continuations, to fix user-visible breakage.
>
> Fixes: 4bcc595ccd80decb ("printk: reinstate KERN_CONT for printing continuation lines")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> arch/m68k/mac/macints.c | 42 ++++++++++++++++++++++--------------------
> 1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/arch/m68k/mac/macints.c b/arch/m68k/mac/macints.c
> index 9f98c08719010e27..8572290cb93b6679 100644
> --- a/arch/m68k/mac/macints.c
> +++ b/arch/m68k/mac/macints.c
> @@ -135,6 +135,11 @@
> irqreturn_t mac_debug_handler(int, void *);
>
> /* #define DEBUG_MACINTS */
> +#ifdef DEBUG_MACINTS
> +#define pr_irq(fmt, ...) printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
> +#else
> +#define pr_irq(fmt, ...) no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
> +#endif
>
> static unsigned int mac_irq_startup(struct irq_data *);
> static void mac_irq_shutdown(struct irq_data *);
I would prefer to delete all the DEBUG_MACINTS clutter.
> @@ -149,20 +154,18 @@
>
> void __init mac_init_IRQ(void)
> {
> -#ifdef DEBUG_MACINTS
> - printk("mac_init_IRQ(): Setting things up...\n");
> -#endif
> + pr_irq("mac_init_IRQ(): Setting things up...\n");
> m68k_setup_irq_controller(&mac_irq_chip, handle_simple_irq, IRQ_USER,
> NUM_MAC_SOURCES - IRQ_USER);
> /* Make sure the SONIC interrupt is cleared or things get ugly */
> #ifdef SHUTUP_SONIC
> - printk("Killing onboard sonic... ");
> + pr_info("Killing onboard sonic... ");
> /* This address should hopefully be mapped already */
> if (hwreg_present((void*)(0x50f0a000))) {
> *(long *)(0x50f0a014) = 0x7fffL;
> *(long *)(0x50f0a010) = 0L;
> }
> - printk("Done.\n");
> + pr_cont("Done.\n");
> #endif /* SHUTUP_SONIC */
>
> /*
> @@ -182,9 +185,7 @@ void __init mac_init_IRQ(void)
> if (request_irq(IRQ_AUTO_7, mac_nmi_handler, 0, "NMI",
> mac_nmi_handler))
> pr_err("Couldn't register NMI\n");
> -#ifdef DEBUG_MACINTS
> - printk("mac_init_IRQ(): Done!\n");
> -#endif
> + pr_irq("mac_init_IRQ(): Done!\n");
> }
>
> /*
> @@ -281,7 +282,7 @@ static void mac_irq_shutdown(struct irq_data *data)
> irqreturn_t mac_debug_handler(int irq, void *dev_id)
> {
> if (num_debug[irq] < 10) {
> - printk("DEBUG: Unexpected IRQ %d\n", irq);
> + pr_info("DEBUG: Unexpected IRQ %d\n", irq);
> num_debug[irq]++;
> }
> return IRQ_HANDLED;
Is this dead code?
> @@ -304,9 +305,9 @@ irqreturn_t mac_nmi_handler(int irq, void *dev_id)
>
> if (in_nmi == 1) {
> nmi_hold = 1;
> - printk("... pausing, press NMI to resume ...");
> + pr_info("... pausing, press NMI to resume ...");
> } else {
> - printk(" ok!\n");
> + pr_cont(" ok!\n");
> nmi_hold = 0;
> }
>
> @@ -319,20 +320,21 @@ irqreturn_t mac_nmi_handler(int irq, void *dev_id)
> #if 0
> struct pt_regs *fp = get_irq_regs();
> show_state();
> - printk("PC: %08lx\nSR: %04x SP: %p\n", fp->pc, fp->sr, fp);
> - printk("d0: %08lx d1: %08lx d2: %08lx d3: %08lx\n",
> - fp->d0, fp->d1, fp->d2, fp->d3);
> - printk("d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
> - fp->d4, fp->d5, fp->a0, fp->a1);
> + pr_info("PC: %08lx\nSR: %04x SP: %p\n", fp->pc, fp->sr, fp);
> + pr_info("d0: %08lx d1: %08lx d2: %08lx d3: %08lx\n",
> + fp->d0, fp->d1, fp->d2, fp->d3);
> + pr_info("d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
> + fp->d4, fp->d5, fp->a0, fp->a1);
>
> if (STACK_MAGIC != *(unsigned long *)current->kernel_stack_page)
> - printk("Corrupted stack page\n");
> - printk("Process %s (pid: %d, stackpage=%08lx)\n",
> - current->comm, current->pid, current->kernel_stack_page);
> + pr_info("Corrupted stack page\n");
> + pr_info("Process %s (pid: %d, stackpage=%08lx)\n",
> + current->comm, current->pid,
> + current->kernel_stack_page);
> if (intr_count == 1)
> dump_stack((struct frame *)fp);
> #else
> - /* printk("NMI "); */
> + /* pr_info("NMI "); */
> #endif
> }
> in_nmi--;
>
I think it would be good to use pr_debug here instead of #if 0. But that
will probably break the build... better ignore the #if 0 section for this
series, until I put together a different patch?
--
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/22] m68k: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 14/22] m68k/q40: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 19/22] m68k/mm: motorola - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 04/22] m68k/68000: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
Re: [PATCH 04/22] m68k/68000: Modernize printing of kernel messages Greg Ungerer <gerg@linux-m68k.org> - 2016-12-09 13:20 +0100
[PATCH 15/22] m68k/sun3: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 02/22] m68k/mac: macints - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
Re: [PATCH 02/22] m68k/mac: macints - Modernize printing of kernel messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-07 23:50 +0100
Re: [PATCH 02/22] m68k/mac: macints - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-08 13:30 +0100
Re: [PATCH 02/22] m68k/mac: macints - Modernize printing of kernel messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-09 00:20 +0100
[PATCH 21/22] m68k/mm: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 11/22] m68k/mac: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
Re: [PATCH 11/22] m68k/mac: Modernize printing of kernel messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-08 00:20 +0100
[PATCH 20/22] m68k/mm: sun3 - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 06/22] m68k/coldfire: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
Re: [PATCH 06/22] m68k/coldfire: Modernize printing of kernel messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-08 00:00 +0100
Re: [PATCH 06/22] m68k/coldfire: Modernize printing of kernel messages Greg Ungerer <gerg@linux-m68k.org> - 2016-12-09 13:10 +0100
[PATCH 22/22] m68k/include: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 13/22] m68k/mvme16x: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 05/22] m68k/bvme6000: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 12/22] m68k/mvme147: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
[PATCH 08/22] m68k/mac: iop - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
Re: [PATCH 08/22] m68k/mac: iop - Modernize printing of kernel messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-08 00:10 +0100
[PATCH 17/22] m68k/kernel: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
csiph-web