[PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

From	Oleg Drokin <green@linuxhacker.ru>
Newsgroups	linux.kernel
Subject	[PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header
Date	2016-12-07 23:50 +0100
Message-ID	<sLTcd-6aD-1@gated-at.bofh.it> (permalink)
References	<sLTcd-6aD-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This avoids frowned upon extern in the C file, and also
shuts down a sparse warning of
drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol 'osc_caches' was not declared. Should it be static?

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
 drivers/staging/lustre/lustre/osc/osc_internal.h | 2 ++
 drivers/staging/lustre/lustre/osc/osc_request.c  | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/osc/osc_internal.h b/drivers/staging/lustre/lustre/osc/osc_internal.h
index 688783d..5cce82b 100644
--- a/drivers/staging/lustre/lustre/osc/osc_internal.h
+++ b/drivers/staging/lustre/lustre/osc/osc_internal.h
@@ -181,6 +181,8 @@ static inline struct osc_device *obd2osc_dev(const struct obd_device *d)
 	return container_of0(d->obd_lu_dev, struct osc_device, od_cl.cd_lu_dev);
 }
 
+extern struct lu_kmem_descr osc_caches[];
+
 extern struct kmem_cache *osc_quota_kmem;
 struct osc_quota_info {
 	/** linkage for quota hash table */
diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustre/lustre/osc/osc_request.c
index 7143564..f691297 100644
--- a/drivers/staging/lustre/lustre/osc/osc_request.c
+++ b/drivers/staging/lustre/lustre/osc/osc_request.c
@@ -2766,8 +2766,6 @@ static struct obd_ops osc_obd_ops = {
 	.quotactl       = osc_quotactl,
 };
 
-extern struct lu_kmem_descr osc_caches[];
-
 static int __init osc_init(void)
 {
 	struct lprocfs_static_vars lvars = { NULL };
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header Oleg Drokin <green@linuxhacker.ru> - 2016-12-07 23:50 +0100
  Re: [PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a  header James Simmons <jsimmons@infradead.org> - 2016-12-08 01:30 +0100

csiph-web