Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539311

Re: [PATCH 04/22] m68k/68000: Modernize printing of kernel messages

From Greg Ungerer <gerg@linux-m68k.org>
Newsgroups linux.kernel
Subject Re: [PATCH 04/22] m68k/68000: Modernize printing of kernel messages
Date 2016-12-09 13:20 +0100
Message-ID <sMsjD-38t-1@gated-at.bofh.it> (permalink)
References <sLMaJ-1Ll-5@gated-at.bofh.it> <sLMaK-1Ll-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Geert,

On 08/12/16 01:09, Geert Uytterhoeven wrote:
> Convert from printk() to pr_*().
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Looks good to me, so:

Acked-by: Greg Ungerer <gerg@linux-m68k.org>

Regards
Greg



> ---
>  arch/m68k/68000/m68328.c   | 6 +++---
>  arch/m68k/68000/m68EZ328.c | 6 +++---
>  arch/m68k/68000/m68VZ328.c | 6 +++---
>  3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/m68k/68000/m68328.c b/arch/m68k/68000/m68328.c
> index e53caf4c3bfbf9d1..419751b15ec8b5f1 100644
> --- a/arch/m68k/68000/m68328.c
> +++ b/arch/m68k/68000/m68328.c
> @@ -45,9 +45,9 @@ void m68328_reset (void)
>
>  void __init config_BSP(char *command, int len)
>  {
> -  printk(KERN_INFO "\n68328 support D. Jeff Dionne <jeff@uclinux.org>\n");
> -  printk(KERN_INFO "68328 support Kenneth Albanowski <kjahds@kjshds.com>\n");
> -  printk(KERN_INFO "68328/Pilot support Bernhard Kuhn <kuhn@lpr.e-technik.tu-muenchen.de>\n");
> +  pr_info("68328 support D. Jeff Dionne <jeff@uclinux.org>\n");
> +  pr_info("68328 support Kenneth Albanowski <kjahds@kjshds.com>\n");
> +  pr_info("68328/Pilot support Bernhard Kuhn <kuhn@lpr.e-technik.tu-muenchen.de>\n");
>
>    mach_hwclk = m68328_hwclk;
>    mach_reset = m68328_reset;
> diff --git a/arch/m68k/68000/m68EZ328.c b/arch/m68k/68000/m68EZ328.c
> index e6ab321f93f832e9..6a309a3cfbfc1953 100644
> --- a/arch/m68k/68000/m68EZ328.c
> +++ b/arch/m68k/68000/m68EZ328.c
> @@ -57,12 +57,12 @@ void __init config_BSP(char *command, int len)
>  {
>    unsigned char *p;
>
> -  printk(KERN_INFO "\n68EZ328 DragonBallEZ support (C) 1999 Rt-Control, Inc\n");
> +  pr_info("68EZ328 DragonBallEZ support (C) 1999 Rt-Control, Inc\n");
>
>  #ifdef CONFIG_UCSIMM
> -  printk(KERN_INFO "uCsimm serial string [%s]\n",getserialnum());
> +  pr_info("uCsimm serial string [%s]\n", getserialnum());
>    p = cs8900a_hwaddr = gethwaddr(0);
> -  printk(KERN_INFO "uCsimm hwaddr %pM\n", p);
> +  pr_info("uCsimm hwaddr %pM\n", p);
>
>    p = getbenv("APPEND");
>    if (p) strcpy(p,command);
> diff --git a/arch/m68k/68000/m68VZ328.c b/arch/m68k/68000/m68VZ328.c
> index 1154bdb220a022cd..81b5491685a4a2ab 100644
> --- a/arch/m68k/68000/m68VZ328.c
> +++ b/arch/m68k/68000/m68VZ328.c
> @@ -150,9 +150,9 @@ static void __init init_hardware(char *command, int size)
>  {
>  	char *p;
>
> -	printk(KERN_INFO "uCdimm serial string [%s]\n", getserialnum());
> +	pr_info("uCdimm serial string [%s]\n", getserialnum());
>  	p = cs8900a_hwaddr = gethwaddr(0);
> -	printk(KERN_INFO "uCdimm hwaddr %pM\n", p);
> +	pr_info("uCdimm hwaddr %pM\n", p);
>  	p = getbenv("APPEND");
>  	if (p)
>  		strcpy(p, command);
> @@ -177,7 +177,7 @@ static void __init init_hardware(char *command, int size)
>
>  void __init config_BSP(char *command, int size)
>  {
> -	printk(KERN_INFO "68VZ328 DragonBallVZ support (c) 2001 Lineo, Inc.\n");
> +	pr_info("68VZ328 DragonBallVZ support (c) 2001 Lineo, Inc.\n");
>
>  	init_hardware(command, size);
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/22] m68k: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 14/22] m68k/q40: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 19/22] m68k/mm: motorola - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 04/22] m68k/68000: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
    Re: [PATCH 04/22] m68k/68000: Modernize printing of kernel messages Greg Ungerer <gerg@linux-m68k.org> - 2016-12-09 13:20 +0100
  [PATCH 15/22] m68k/sun3: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 02/22] m68k/mac: macints - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
    Re: [PATCH 02/22] m68k/mac: macints - Modernize printing of kernel  messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-07 23:50 +0100
      Re: [PATCH 02/22] m68k/mac: macints - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-08 13:30 +0100
        Re: [PATCH 02/22] m68k/mac: macints - Modernize printing of kernel  messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-09 00:20 +0100
  [PATCH 21/22] m68k/mm: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 11/22] m68k/mac: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
    Re: [PATCH 11/22] m68k/mac: Modernize printing of kernel messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-08 00:20 +0100
  [PATCH 20/22] m68k/mm: sun3 - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 06/22] m68k/coldfire: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
    Re: [PATCH 06/22] m68k/coldfire: Modernize printing of kernel  messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-08 00:00 +0100
      Re: [PATCH 06/22] m68k/coldfire: Modernize printing of kernel  messages Greg Ungerer <gerg@linux-m68k.org> - 2016-12-09 13:10 +0100
  [PATCH 22/22] m68k/include: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 13/22] m68k/mvme16x: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 05/22] m68k/bvme6000: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 12/22] m68k/mvme147: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
  [PATCH 08/22] m68k/mac: iop - Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100
    Re: [PATCH 08/22] m68k/mac: iop - Modernize printing of kernel  messages Finn Thain <fthain@telegraphics.com.au> - 2016-12-08 00:10 +0100
  [PATCH 17/22] m68k/kernel: Modernize printing of kernel messages Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-07 16:20 +0100

csiph-web