[PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count

From	Andreas Färber <afaerber@suse.de>
Newsgroups	linux.kernel
Subject	[PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count
Date	2016-11-27 21:50 +0100
Message-ID	<sIeyB-R6-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings,
so free the same amount. This will be 8 or 9 in practice, less than 16.

Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.")
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 98302358ceb9..95b9efb33ec7 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -421,7 +421,7 @@ static void mv88e6xxx_g1_irq_free(struct mv88e6xxx_chip *chip)
 
 	free_irq(chip->irq, chip);
 
-	for (irq = 0; irq < 16; irq++) {
+	for (irq = 0; irq < chip->g1_irq.nirqs; irq++) {
 		virq = irq_find_mapping(chip->g1_irq.domain, irq);
 		irq_dispose_mapping(virq);
 	}
-- 
2.6.6

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andreas Färber <afaerber@suse.de> - 2016-11-27 21:50 +0100
  Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andrew Lunn <andrew@lunn.ch> - 2016-11-27 22:30 +0100
    Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andreas Färber <afaerber@suse.de> - 2016-11-27 22:40 +0100
      Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andrew Lunn <andrew@lunn.ch> - 2016-11-27 22:40 +0100

csiph-web