Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1530926 > unrolled thread
| Started by | Andreas Färber <afaerber@suse.de> |
|---|---|
| First post | 2016-11-27 21:50 +0100 |
| Last post | 2016-11-27 22:40 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andreas Färber <afaerber@suse.de> - 2016-11-27 21:50 +0100
Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andrew Lunn <andrew@lunn.ch> - 2016-11-27 22:30 +0100
Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andreas Färber <afaerber@suse.de> - 2016-11-27 22:40 +0100
Re: [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count Andrew Lunn <andrew@lunn.ch> - 2016-11-27 22:40 +0100
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2016-11-27 21:50 +0100 |
| Subject | [PATCH] mv88e6xxx: Fix mv88e6xxx_g1_irq_free() interrupt count |
| Message-ID | <sIeyB-R6-9@gated-at.bofh.it> |
mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings,
so free the same amount. This will be 8 or 9 in practice, less than 16.
Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.")
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 98302358ceb9..95b9efb33ec7 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -421,7 +421,7 @@ static void mv88e6xxx_g1_irq_free(struct mv88e6xxx_chip *chip)
free_irq(chip->irq, chip);
- for (irq = 0; irq < 16; irq++) {
+ for (irq = 0; irq < chip->g1_irq.nirqs; irq++) {
virq = irq_find_mapping(chip->g1_irq.domain, irq);
irq_dispose_mapping(virq);
}
--
2.6.6
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2016-11-27 22:30 +0100 |
| Message-ID | <sIfbj-1jb-1@gated-at.bofh.it> |
| In reply to | #1530926 |
On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote:
> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings,
> so free the same amount. This will be 8 or 9 in practice, less than 16.
Hi Andreas
The patch is correct, but please read
Documentation/networking/netdev-FAQ.txt
and then resubmit the patch.
Andrew
>
> Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 98302358ceb9..95b9efb33ec7 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -421,7 +421,7 @@ static void mv88e6xxx_g1_irq_free(struct mv88e6xxx_chip *chip)
>
> free_irq(chip->irq, chip);
>
> - for (irq = 0; irq < 16; irq++) {
> + for (irq = 0; irq < chip->g1_irq.nirqs; irq++) {
> virq = irq_find_mapping(chip->g1_irq.domain, irq);
> irq_dispose_mapping(virq);
> }
> --
> 2.6.6
>
[toc] | [prev] | [next] | [standalone]
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2016-11-27 22:40 +0100 |
| Message-ID | <sIfl0-1mC-15@gated-at.bofh.it> |
| In reply to | #1530934 |
Hi Andrew, Am 27.11.2016 um 22:22 schrieb Andrew Lunn: > On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote: >> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, >> so free the same amount. This will be 8 or 9 in practice, less than 16. > > Hi Andreas > > The patch is correct, but please read > Documentation/networking/netdev-FAQ.txt > and then resubmit the patch. Do you mean --subject-prefix="PATCH net-next" or something else? Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2016-11-27 22:40 +0100 |
| Message-ID | <sIfl0-1mC-13@gated-at.bofh.it> |
| In reply to | #1530940 |
On Sun, Nov 27, 2016 at 10:32:41PM +0100, Andreas Färber wrote: > Hi Andrew, > > Am 27.11.2016 um 22:22 schrieb Andrew Lunn: > > On Sun, Nov 27, 2016 at 09:43:44PM +0100, Andreas Färber wrote: > >> mv88e6xxx_g1_irq_setup() sets up chip->g1_irq.nirqs interrupt mappings, > >> so free the same amount. This will be 8 or 9 in practice, less than 16. > > > > Hi Andreas > > > > The patch is correct, but please read > > Documentation/networking/netdev-FAQ.txt > > and then resubmit the patch. > > Do you mean --subject-prefix="PATCH net-next" Yep. Thanks Andrew
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web