Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK
Date	2016-11-27 21:50 +0100
Message-ID	<sIeyB-R6-5@gated-at.bofh.it> (permalink)
References	<sGUsi-6pb-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 24 Nov 2016 07:04:08 +0200

> sparse warns about context imbalance in any code
> that uses HARD_TX_LOCK/UNLOCK - this is because it's
> unable to determine that flags don't change so
> lock and unlock are paired.
> 
> Seems easy enough to fix by adding __acquire/__release
> calls.
> 
> With this patch af_packet.c is now sparse-clean,
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK David Miller <davem@davemloft.net> - 2016-11-27 21:50 +0100

csiph-web