Re: [PATCH] cxgb4: fix memory leak on txq_info

From	Colin Ian King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cxgb4: fix memory leak on txq_info
Date	2016-11-25 22:30 +0100
Message-ID	<sHwee-5RF-9@gated-at.bofh.it> (permalink)
References	<sGDB8-45R-23@gated-at.bofh.it> <sHw4y-5Op-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 25/11/16 21:10, David Miller wrote:
> From: Colin King <colin.king@canonical.com>
> Date: Wed, 23 Nov 2016 11:02:44 +0000
> 
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently if txq_info->uldtxq cannot be allocated then
>> txq_info->txq is being kfree'd (which is redundant because it
>> is NULL) instead of txq_info. Fix this by instead kfree'ing
>> txq_info.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Applied, but Colin you _really_ need to start properly marking your
> networking patch submissions by indicating in the subject which
> tree your change is for.  In this case I figured out it was
> net-next, but you must say this explicitly in the Subject line
> via "Subject: [PATCH net-next] ..."
> 
> Thanks.
> 
Understood, will do next time, apologies for that.

Colin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] cxgb4: fix memory leak on txq_info David Miller <davem@davemloft.net> - 2016-11-25 22:20 +0100
  Re: [PATCH] cxgb4: fix memory leak on txq_info Colin Ian King <colin.king@canonical.com> - 2016-11-25 22:30 +0100

csiph-web