Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530539

Re: [PATCH] xen-scsifront: Add a missing call to kfree

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] xen-scsifront: Add a missing call to kfree
Date 2016-11-25 22:30 +0100
Message-ID <sHwee-5RF-11@gated-at.bofh.it> (permalink)
References <sFiyK-5C-51@gated-at.bofh.it> <sFPXI-5Q1-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 21, 2016 at 07:01:36AM +0100, Juergen Gross wrote:
> On 19/11/16 19:22, Quentin Lambert wrote:
> > Most error branches following the call to kmalloc contain
> > a call to kfree. This patch add these calls where they are
> > missing.
> > 
> > This issue was found with Hector.
> > 
> > Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
> 
> Nice catch. I think this will need some more work, I'll do a
> follow-on patch.

Yeah.  It's weird how we free it on the success path and all the failure
paths except one.  But it looks so deliberate.  What's going on with
that?

Could you send your follow on patch as a reply to the thread?

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] xen-scsifront: Add a missing call to kfree Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-25 22:30 +0100
  [PATCH] xen/scsifront: don't advance ring request pointer in case of error Juergen Gross <jgross@suse.com> - 2016-11-29 12:00 +0100
    Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring  request pointer in case of error "Jan Beulich" <JBeulich@suse.com> - 2016-11-29 12:20 +0100
    Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request  pointer in case of error Juergen Gross <jgross@suse.com> - 2016-11-29 12:20 +0100
      Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request  pointer in case of error David Vrabel <david.vrabel@citrix.com> - 2016-11-29 12:40 +0100
        Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request  pointer in case of error Juergen Gross <jgross@suse.com> - 2016-11-29 12:40 +0100
      Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring  request pointer in case of error "Jan Beulich" <JBeulich@suse.com> - 2016-11-29 12:50 +0100
      Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request  pointer in case of error Juergen Gross <jgross@suse.com> - 2016-11-29 13:40 +0100
  [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready Juergen Gross <jgross@suse.com> - 2016-12-02 07:20 +0100
  [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready Juergen Gross <jgross@suse.com> - 2016-12-02 07:20 +0100
  [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready Juergen Gross <jgross@suse.com> - 2016-12-02 07:20 +0100
    Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until  request is ready Juergen Gross <jgross@suse.com> - 2016-12-05 16:40 +0100
    Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until  request is ready Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-12-05 16:40 +0100
    Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until  request is ready Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-12-08 16:00 +0100
    Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until  request is ready Juergen Gross <jgross@suse.com> - 2016-12-09 11:20 +0100

csiph-web