Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1530534 > unrolled thread

Re: [PATCH] cxgb4: fix memory leak on txq_info

Started byDavid Miller <davem@davemloft.net>
First post2016-11-25 22:20 +0100
Last post2016-11-25 22:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] cxgb4: fix memory leak on txq_info David Miller <davem@davemloft.net> - 2016-11-25 22:20 +0100
    Re: [PATCH] cxgb4: fix memory leak on txq_info Colin Ian King <colin.king@canonical.com> - 2016-11-25 22:30 +0100

#1530534 — Re: [PATCH] cxgb4: fix memory leak on txq_info

FromDavid Miller <davem@davemloft.net>
Date2016-11-25 22:20 +0100
SubjectRe: [PATCH] cxgb4: fix memory leak on txq_info
Message-ID<sHw4y-5Op-15@gated-at.bofh.it>
From: Colin King <colin.king@canonical.com>
Date: Wed, 23 Nov 2016 11:02:44 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently if txq_info->uldtxq cannot be allocated then
> txq_info->txq is being kfree'd (which is redundant because it
> is NULL) instead of txq_info. Fix this by instead kfree'ing
> txq_info.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, but Colin you _really_ need to start properly marking your
networking patch submissions by indicating in the subject which
tree your change is for.  In this case I figured out it was
net-next, but you must say this explicitly in the Subject line
via "Subject: [PATCH net-next] ..."

Thanks.

[toc] | [next] | [standalone]


#1530538

FromColin Ian King <colin.king@canonical.com>
Date2016-11-25 22:30 +0100
Message-ID<sHwee-5RF-9@gated-at.bofh.it>
In reply to#1530534
On 25/11/16 21:10, David Miller wrote:
> From: Colin King <colin.king@canonical.com>
> Date: Wed, 23 Nov 2016 11:02:44 +0000
> 
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently if txq_info->uldtxq cannot be allocated then
>> txq_info->txq is being kfree'd (which is redundant because it
>> is NULL) instead of txq_info. Fix this by instead kfree'ing
>> txq_info.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Applied, but Colin you _really_ need to start properly marking your
> networking patch submissions by indicating in the subject which
> tree your change is for.  In this case I figured out it was
> net-next, but you must say this explicitly in the Subject line
> via "Subject: [PATCH net-next] ..."
> 
> Thanks.
> 
Understood, will do next time, apologies for that.

Colin

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web