Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528296

Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2]

Show all headers | View raw

On 23 November 2016 at 09:34, David Howells <dhowells@redhat.com> wrote:
> David Howells <dhowells@redhat.com> wrote:
>
>> +#define efi_call_runtime(f, ...)     sys_table_arg->runtime->f(__VA_ARGS__)
>
> Turns out it's not that simple - of course.  runtime->get_variable is just a
> void pointer.  The old arm stub was casting it by virtue of assignment to a
> function pointer variable.
>
> The x86_64 appears to be doing bypassing all the compile-time type checking by
> passing the arguments through an ellipsis and then fixing up the argument list
> in the ->call() function.
>
> What I've changed the ARM and ARM64 things to is:
>
>         #define efi_call_runtime(f, ...)        ((efi_##f##_t *)sys_table_arg->runtime->f)(__VA_ARGS__)
>

Could we please instead fix the definition of efi_runtime_services_t,
given that we have typedefs already for all its members?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] efi: Pass secure boot mode to kernel [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 3/6] efi: Add SHIM and image security database GUID  definitions [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 1/6] x86/efi: Allow invocation of arbitrary runtime services  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 10:40 +0100
      Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-23 11:40 +0100
        Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 13:00 +0100
    Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 11:40 +0100
      Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 12:50 +0100
        Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:40 +0100
  [PATCH 5/6] efi: Disable secure boot if shim is in insecure mode  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 5/6] efi: Disable secure boot if shim is in insecure mode  [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:40 +0100
  [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Lukas Wunner <lukas@wunner.de> - 2016-11-23 10:40 +0100
      Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 11:00 +0100
        Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Lukas Wunner <lukas@wunner.de> - 2016-11-23 11:20 +0100
    Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 11:50 +0100
      Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 12:30 +0100
        Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:50 +0100
          Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 15:20 +0100
            Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 16:00 +0100
            Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 16:10 +0100

csiph-web