Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528411

Re: [PATCH 5/6] efi: Disable secure boot if shim is in insecure mode [ver #2]

Show all headers | View raw

On Wed, Nov 23, 2016 at 12:23:04AM +0000, David Howells wrote:
> +	/* See if a user has put shim into insecure mode.  If so, and if the
> +	 * variable doesn't have the runtime attribute set, we might as well
> +	 * honor that.
> +	 */
> +	size = sizeof(moksbstate);
> +	status = get_efi_var(shim_MokSBState_name, &shim_guid,
> +			     &attr, &size, &moksbstate);
> +
> +	/* If it fails, we don't care why.  Default to secure */
> +	if (status != EFI_SUCCESS)
> +		return 1;

I was going to suggest branching to out_efi_err, but I see that wouldn't
work when EFI_NOT_FOUND was returned. It might be worth noting
explicitly that we can't use that, so as to avoid 'obvious' cleanup in
future.

Thanks,
Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] efi: Pass secure boot mode to kernel [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 3/6] efi: Add SHIM and image security database GUID  definitions [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 1/6] x86/efi: Allow invocation of arbitrary runtime services  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 10:40 +0100
      Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-23 11:40 +0100
        Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 13:00 +0100
    Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 11:40 +0100
      Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 12:50 +0100
        Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:40 +0100
  [PATCH 5/6] efi: Disable secure boot if shim is in insecure mode  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 5/6] efi: Disable secure boot if shim is in insecure mode  [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:40 +0100
  [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Lukas Wunner <lukas@wunner.de> - 2016-11-23 10:40 +0100
      Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 11:00 +0100
        Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Lukas Wunner <lukas@wunner.de> - 2016-11-23 11:20 +0100
    Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 11:50 +0100
      Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 12:30 +0100
        Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:50 +0100
          Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 15:20 +0100
            Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 16:00 +0100
            Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 16:10 +0100

csiph-web