Re: [PATCH 4/6] efi: Get the secure boot status [ver #2]

From	Lukas Wunner <lukas@wunner.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] efi: Get the secure boot status [ver #2]
Date	2016-11-23 11:20 +0100
Message-ID	<sGCOK-3Ax-35@gated-at.bofh.it> (permalink)
References	<sGCc2-33w-15@gated-at.bofh.it> <sGtBL-60o-3@gated-at.bofh.it> <sGtLr-63s-9@gated-at.bofh.it> <sGCvn-3a3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 23, 2016 at 09:53:00AM +0000, David Howells wrote:
> Lukas Wunner <lukas@wunner.de> wrote:
> > It just occurred to me that the boot_params struct is populated in
> > make_boot_params(), perhaps it makes sense to move this line there.
> > Otherwise LGTM.
> 
> Ummm...  Looking at arch/x86/boot/compressed/head_64.S, make_boot_params() is
> only called if the stub is entered through efi_pe_entry, not if entered
> through efi64_stub_entry, whereas efi_main() is called in both cases.  I think
> entry through efi32_stub_entry may also skip make_boot_params().
> 
> The comment on make_boot_params() suggests that this function is only used if
> whoever booted the kernel didn't supply it.

Good point. :-) I didn't dig this deep, it was just something that
crossed my mind when skimming over the patch.

You're also right about the (efi_##f##_t *) addition in patch 2.

Thanks,

Lukas

Thread

[PATCH 0/6] efi: Pass secure boot mode to kernel [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 3/6] efi: Add SHIM and image security database GUID  definitions [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 1/6] x86/efi: Allow invocation of arbitrary runtime services  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:30 +0100
  [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 10:40 +0100
      Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-23 11:40 +0100
        Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 13:00 +0100
    Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 11:40 +0100
      Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 12:50 +0100
        Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime  services [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:40 +0100
  [PATCH 5/6] efi: Disable secure boot if shim is in insecure mode  [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 5/6] efi: Disable secure boot if shim is in insecure mode  [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:40 +0100
  [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 01:40 +0100
    Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Lukas Wunner <lukas@wunner.de> - 2016-11-23 10:40 +0100
      Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 11:00 +0100
        Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Lukas Wunner <lukas@wunner.de> - 2016-11-23 11:20 +0100
    Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 11:50 +0100
      Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 12:30 +0100
        Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 14:50 +0100
          Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 15:20 +0100
            Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] David Howells <dhowells@redhat.com> - 2016-11-23 16:00 +0100
            Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] Mark Rutland <mark.rutland@arm.com> - 2016-11-23 16:10 +0100

csiph-web