Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527060

[PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port

Show all headers | View raw

We already log a "Signaling PME" whenever the PME service driver claims a
Root Port.  In fact, we also log the same message for every device in the
hierarchy below the Root Port.

Log the "Signaling PME" once (only for the Root Port, since we can
trivially find out which devices are below the Root Port), and include the
IRQ number in the message to help connect the dots with /proc/interrupts.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/pcie/pme.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index 9e8aa9d..7175293 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -300,8 +300,6 @@ static irqreturn_t pcie_pme_irq(int irq, void *context)
  */
 static int pcie_pme_set_native(struct pci_dev *dev, void *ign)
 {
-	dev_info(&dev->dev, "Signaling PME through PCIe PME interrupt\n");
-
 	device_set_run_wake(&dev->dev, true);
 	dev->pme_interrupt = true;
 	return 0;
@@ -349,12 +347,14 @@ static int pcie_pme_probe(struct pcie_device *srv)
 	ret = request_irq(srv->irq, pcie_pme_irq, IRQF_SHARED, "PCIe PME", srv);
 	if (ret) {
 		kfree(data);
-	} else {
-		pcie_pme_mark_devices(port);
-		pcie_pme_interrupt_enable(port, true);
+		return ret;
 	}
 
-	return ret;
+	dev_info(&port->dev, "Signaling PME with IRQ %d\n", srv->irq);
+
+	pcie_pme_mark_devices(port);
+	pcie_pme_interrupt_enable(port, true);
+	return 0;
 }
 
 static bool pcie_pme_check_wakeup(struct pci_bus *bus)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
    Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-21 23:30 +0100
      Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-21 23:50 +0100
        Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-22 00:00 +0100
          Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-22 00:10 +0100
  [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
    Re: [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-21 23:30 +0100
  [PATCH v2 8/9] PCI: pciehp: Remove loading message Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 3/9] PCI/AER: Remove unused version macros Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 7/9] PCI: hotplug: Remove hotplug core message Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 6/9] PCI: Remove service driver load/unload messages Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 4/9] PCI/AER: Log errors with PCI device,  not PCIe service device Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  Re: [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas <helgaas@kernel.org> - 2016-11-23 18:40 +0100

csiph-web