Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527067

[PATCH v2 4/9] PCI/AER: Log errors with PCI device, not PCIe service device

Show all headers | View raw

All other AER-related log messages use the PCI device, e.g.,
"pci 0000:00:1c.0", not the PCIe service device, e.g.,
"aer 0000:00:1c.0:pcie02".

Change the probe error messages to match the rest and include a little
context.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/pcie/aer/aerdrv.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c
index 1c189e6..60e63d6 100644
--- a/drivers/pci/pcie/aer/aerdrv.c
+++ b/drivers/pci/pcie/aer/aerdrv.c
@@ -290,12 +290,12 @@ static int aer_probe(struct pcie_device *dev)
 {
 	int status;
 	struct aer_rpc *rpc;
-	struct device *device = &dev->device;
+	struct device *device = &dev->port->dev;
 
 	/* Alloc rpc data structure */
 	rpc = aer_alloc_rpc(dev);
 	if (!rpc) {
-		dev_printk(KERN_DEBUG, device, "alloc rpc failed\n");
+		dev_printk(KERN_DEBUG, device, "alloc AER rpc failed\n");
 		aer_remove(dev);
 		return -ENOMEM;
 	}
@@ -303,7 +303,8 @@ static int aer_probe(struct pcie_device *dev)
 	/* Request IRQ ISR */
 	status = request_irq(dev->irq, aer_irq, IRQF_SHARED, "aerdrv", dev);
 	if (status) {
-		dev_printk(KERN_DEBUG, device, "request IRQ failed\n");
+		dev_printk(KERN_DEBUG, device, "request AER IRQ %d failed\n",
+			   dev->irq);
 		aer_remove(dev);
 		return status;
 	}

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
    Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-21 23:30 +0100
      Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-21 23:50 +0100
        Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-22 00:00 +0100
          Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-22 00:10 +0100
  [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
    Re: [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-21 23:30 +0100
  [PATCH v2 8/9] PCI: pciehp: Remove loading message Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 3/9] PCI/AER: Remove unused version macros Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 7/9] PCI: hotplug: Remove hotplug core message Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 6/9] PCI: Remove service driver load/unload messages Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 4/9] PCI/AER: Log errors with PCI device,  not PCIe service device Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  Re: [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas <helgaas@kernel.org> - 2016-11-23 18:40 +0100

csiph-web