Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527059

[PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors

Show all headers | View raw

Since we register pcie_pme_driver only for PCI_EXP_TYPE_ROOT_PORT, the PME
driver never claims Root Complex Event Collectors.

Remove unused code related to Root Complex Event Collectors.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/pcie/pme.c |   17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index 884bad5..9e8aa9d 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -319,23 +319,8 @@ static int pcie_pme_set_native(struct pci_dev *dev, void *ign)
 static void pcie_pme_mark_devices(struct pci_dev *port)
 {
 	pcie_pme_set_native(port, NULL);
-	if (port->subordinate) {
+	if (port->subordinate)
 		pci_walk_bus(port->subordinate, pcie_pme_set_native, NULL);
-	} else {
-		struct pci_bus *bus = port->bus;
-		struct pci_dev *dev;
-
-		/* Check if this is a root port event collector. */
-		if (pci_pcie_type(port) != PCI_EXP_TYPE_RC_EC || !bus)
-			return;
-
-		down_read(&pci_bus_sem);
-		list_for_each_entry(dev, &bus->devices, bus_list)
-			if (pci_is_pcie(dev)
-			    && pci_pcie_type(dev) == PCI_EXP_TYPE_RC_END)
-				pcie_pme_set_native(dev, NULL);
-		up_read(&pci_bus_sem);
-	}
 }
 
 /**

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
    Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-21 23:30 +0100
      Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-21 23:50 +0100
        Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root Complex Event Collectors "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-22 00:00 +0100
          Re: [PATCH v2 1/9] PCI/PME: Drop unused support for PMEs from Root  Complex Event Collectors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-22 00:10 +0100
  [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
    Re: [PATCH v2 2/9] PCI/PME: Log PME IRQ when claiming Root Port "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-21 23:30 +0100
  [PATCH v2 8/9] PCI: pciehp: Remove loading message Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 3/9] PCI/AER: Remove unused version macros Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 7/9] PCI: hotplug: Remove hotplug core message Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 6/9] PCI: Remove service driver load/unload messages Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  [PATCH v2 4/9] PCI/AER: Log errors with PCI device,  not PCIe service device Bjorn Helgaas <bhelgaas@google.com> - 2016-11-21 22:50 +0100
  Re: [PATCH v2 0/9] PCI: Tidy up messages Bjorn Helgaas <helgaas@kernel.org> - 2016-11-23 18:40 +0100

csiph-web