Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1516239

Re: [PATCHv3 15/41] filemap: handle huge pages in do_generic_file_read()

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCHv3 15/41] filemap: handle huge pages in do_generic_file_read()
Date 2016-11-07 16:00 +0100
Message-ID <sATyV-4uf-7@gated-at.bofh.it> (permalink)
References (3 earlier) <syplD-5Zo-1@gated-at.bofh.it> <syKq5-2Hy-19@gated-at.bofh.it> <syZfs-3TD-13@gated-at.bofh.it> <szxh7-sf-7@gated-at.bofh.it> <sAQro-2rT-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 07, 2016 at 02:07:36PM +0300, Kirill A. Shutemov wrote:
> Just to clarify: is it show-stopper or we can live with buffer_head list
> for now?

I'm not Jan, but I will NAK anything that looks like the current THP
series.  It's a great prototype, but it also shows up all the area
that we need to fix first, and the buffer_head chain is one of them.

> Hm. Okay, I'll try to check what I can do to make it more maintainable.
> My worry is that it will make the patchset even bigger...

So start splitting out parts that are useful on their own, or spent
time on fixing fundamental underlying issues that will make it smaller
as a side effect.  That's how everyone else does kernel development.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-10-31 19:20 +0100
  Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Jan Kara <jack@suse.cz> - 2016-11-01 17:50 +0100
    Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-02 09:40 +0100
      Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Christoph Hellwig <hch@infradead.org> - 2016-11-02 15:40 +0100
      Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Jan Kara <jack@suse.cz> - 2016-11-03 22:00 +0100
        Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-07 12:40 +0100
          Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Christoph Hellwig <hch@infradead.org> - 2016-11-07 16:00 +0100
    Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Christoph Hellwig <hch@infradead.org> - 2016-11-02 15:40 +0100
      Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Jan Kara <jack@suse.cz> - 2016-11-03 19:00 +0100
      Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-07 12:40 +0100
        Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Christoph Hellwig <hch@infradead.org> - 2016-11-07 16:30 +0100
          Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-11-07 17:10 +0100

csiph-web