Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1516251

Re: [PATCHv3 15/41] filemap: handle huge pages in do_generic_file_read()

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCHv3 15/41] filemap: handle huge pages in do_generic_file_read()
Date 2016-11-07 16:30 +0100
Message-ID <sAU1Y-4T4-37@gated-at.bofh.it> (permalink)
References (2 earlier) <srNMb-3Dq-21@gated-at.bofh.it> <syplD-5Zo-1@gated-at.bofh.it> <syKq5-2Hy-19@gated-at.bofh.it> <sz4RP-7vs-25@gated-at.bofh.it> <sAQro-2rT-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 07, 2016 at 02:13:05PM +0300, Kirill A. Shutemov wrote:
> It looks like a huge limitation to me.

The DAX PMD fault code can live just fine with it.  And without it
performance would suck anyway.

> I'm looking onto iomap_write_actor(): we still calculate 'offset' and
> 'bytes' based on PAGE_SIZE before we even get the page.
> This way we limit outself to PAGE_SIZE per-iteration.

Of course it does, given that it does not support huge pages _yet_.
But the important part is that this is now isolate to the highlevel
code, and the fs can get iomap_begin calls for a huge page (or in fact
much larger sizes than that).

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-10-31 19:20 +0100
  Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Jan Kara <jack@suse.cz> - 2016-11-01 17:50 +0100
    Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-02 09:40 +0100
      Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Christoph Hellwig <hch@infradead.org> - 2016-11-02 15:40 +0100
      Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Jan Kara <jack@suse.cz> - 2016-11-03 22:00 +0100
        Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-07 12:40 +0100
          Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Christoph Hellwig <hch@infradead.org> - 2016-11-07 16:00 +0100
    Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Christoph Hellwig <hch@infradead.org> - 2016-11-02 15:40 +0100
      Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Jan Kara <jack@suse.cz> - 2016-11-03 19:00 +0100
      Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-11-07 12:40 +0100
        Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() Christoph Hellwig <hch@infradead.org> - 2016-11-07 16:30 +0100
          Re: [PATCHv3 15/41] filemap: handle huge pages in  do_generic_file_read() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-11-07 17:10 +0100

csiph-web