Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466891

Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

Show all headers | View raw

Hi Marcus,

On Sun, Aug 21, 2016 at 2:46 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 20 Aug 2016 18:21:29 +0200
>
> Remove a jump label which is unneeded in this function at the end.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/net/wireless/intersil/hostap/hostap_ioctl.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
> index 4e271f9..5942917 100644
> --- a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
> +++ b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c
> @@ -3835,14 +3835,12 @@ static int prism2_ioctl_priv_hostapd(local_info_t *local, struct iw_point *p)
>         }
>
>         if (ret == 1 || !ap_ioctl) {
> -               if (copy_to_user(p->pointer, param, p->length)) {
> +               if (copy_to_user(p->pointer, param, p->length))
>                         ret = -EFAULT;
> -                       goto out;
> -               } else if (ap_ioctl)
> +               else if (ap_ioctl)
>                         ret = 0;
>         }
>
> - out:

Does this change make any difference to the compiled code?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] hostap: Fine-tuning for a few functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
  [PATCH 3/3] hostap: Delete unnecessary initialisations for the  variable "ret" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
  [PATCH 2/3] hostap: Delete an unnecessary jump label in  prism2_ioctl_priv_hostapd() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
    Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() Julian Calaby <julian.calaby@gmail.com> - 2016-08-21 03:50 +0200
  [PATCH 1/3] hostap: Use memdup_user() rather than duplicating its  implementation SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
  Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-08-20 21:30 +0200
    Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Kalle Valo <kvalo@codeaurora.org> - 2016-08-22 17:50 +0200
      Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Joe Perches <joe@perches.com> - 2016-08-22 18:30 +0200
      [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS Joe Perches <joe@perches.com> - 2016-08-22 20:20 +0200
        Re: [PATCH] checkpatch: See if modified files are marked obsolete in  MAINTAINERS SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-22 23:00 +0200
          Re: [PATCH] checkpatch: See if modified files are marked obsolete  in MAINTAINERS Joe Perches <joe@perches.com> - 2016-08-22 23:00 +0200
        Re: checkpatch: See if modified files are marked obsolete in  MAINTAINERS SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-23 09:30 +0200
          Re: checkpatch: See if modified files are marked obsolete in  MAINTAINERS Julia Lawall <julia.lawall@lip6.fr> - 2016-08-23 12:20 +0200

csiph-web