Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1468041
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS |
| Date | 2016-08-22 23:00 +0200 |
| Message-ID | <s94u5-2Ol-17@gated-at.bofh.it> (permalink) |
| References | <s8ZE6-89K-31@gated-at.bofh.it> <s91Zf-1iX-1@gated-at.bofh.it> <s94u5-2Ol-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2016-08-22 at 22:50 +0200, SF Markus Elfring wrote:
> > @@ -2289,6 +2299,10 @@ sub process {
> > }
> >
> > if ($found_file) {
> > + if (is_maintained_obsolete($realfile)) {
> > + WARN("OBSOLETE",
> > + "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.\n");
> > + }
> How do you think about to avoid a double negation in such a warning message?
>
> Would a wording like "… Only really necessary modifications please.\n"
> be more useful here?
No, probably not.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] hostap: Fine-tuning for a few functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
[PATCH 3/3] hostap: Delete unnecessary initialisations for the variable "ret" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
[PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() Julian Calaby <julian.calaby@gmail.com> - 2016-08-21 03:50 +0200
[PATCH 1/3] hostap: Use memdup_user() rather than duplicating its implementation SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-08-20 21:30 +0200
Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Kalle Valo <kvalo@codeaurora.org> - 2016-08-22 17:50 +0200
Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Joe Perches <joe@perches.com> - 2016-08-22 18:30 +0200
[PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS Joe Perches <joe@perches.com> - 2016-08-22 20:20 +0200
Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-22 23:00 +0200
Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS Joe Perches <joe@perches.com> - 2016-08-22 23:00 +0200
Re: checkpatch: See if modified files are marked obsolete in MAINTAINERS SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-23 09:30 +0200
Re: checkpatch: See if modified files are marked obsolete in MAINTAINERS Julia Lawall <julia.lawall@lip6.fr> - 2016-08-23 12:20 +0200
csiph-web