Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1468040

Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

Show all headers | View raw

> @@ -2289,6 +2299,10 @@ sub process {
>  		}
>  
>  		if ($found_file) {
> +			if (is_maintained_obsolete($realfile)) {
> +				WARN("OBSOLETE",
> +				     "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
> +			}

How do you think about to avoid a double negation in such a warning message?

Would a wording like "… Only really necessary modifications please.\n"
be more useful here?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] hostap: Fine-tuning for a few functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
  [PATCH 3/3] hostap: Delete unnecessary initialisations for the  variable "ret" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
  [PATCH 2/3] hostap: Delete an unnecessary jump label in  prism2_ioctl_priv_hostapd() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
    Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() Julian Calaby <julian.calaby@gmail.com> - 2016-08-21 03:50 +0200
  [PATCH 1/3] hostap: Use memdup_user() rather than duplicating its  implementation SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-20 18:50 +0200
  Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-08-20 21:30 +0200
    Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Kalle Valo <kvalo@codeaurora.org> - 2016-08-22 17:50 +0200
      Re: [PATCH 0/3] hostap: Fine-tuning for a few functions Joe Perches <joe@perches.com> - 2016-08-22 18:30 +0200
      [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS Joe Perches <joe@perches.com> - 2016-08-22 20:20 +0200
        Re: [PATCH] checkpatch: See if modified files are marked obsolete in  MAINTAINERS SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-22 23:00 +0200
          Re: [PATCH] checkpatch: See if modified files are marked obsolete  in MAINTAINERS Joe Perches <joe@perches.com> - 2016-08-22 23:00 +0200
        Re: checkpatch: See if modified files are marked obsolete in  MAINTAINERS SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-23 09:30 +0200
          Re: checkpatch: See if modified files are marked obsolete in  MAINTAINERS Julia Lawall <julia.lawall@lip6.fr> - 2016-08-23 12:20 +0200

csiph-web