Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1455410

Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro

From Olof Johansson <olof@lixom.net>
Newsgroups linux.kernel
Subject Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro
Date 2016-08-02 21:10 +0200
Message-ID <s1NeG-gB-47@gated-at.bofh.it> (permalink)
References <s1MiE-84F-121@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Aug 02, 2016 at 06:45:15PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

Am I the only one who find the readability to be MUCH better for the
numeric values?


-Olof

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0157/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 20:10 +0200
  Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro Olof Johansson <olof@lixom.net> - 2016-08-02 21:10 +0200
    Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro Segher Boessenkool <segher@kernel.crashing.org> - 2016-08-02 22:40 +0200

csiph-web