Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1396367

Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings

Show all headers | View raw

On 07/05/16 13:59, Ben Hutchings wrote:
> On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote:
>> The callback {get|set}_link_ksettings are often defined
>> in a very close way. There are mainly two differences in
>> those callback:
>> - the name of the netdev private structure
>> - the name of the struct phydev in the private structure
>>
>> We add two defines ethtool_phy_{get|set}_link_ksettings
>> to avoid writing severals times almost the same function.
> [...]
>
> I don't think there's no need to access a private structure, as there's
> a phydev pointer in struct net_device.  If some drivers don't maintain
> that pointer, they should be changed to do so.  Then they can
> use generic implementations of {get,set}_link_ksettings provided by
> phylib.

If we could use the phydev in the struct net_device, we could write a
generic function for {get|set}_link_ksettings. It's a good idea.

But I've quickly looked and a lot of ethernet driver use the private
structure to store the phydev. If the ethernet driver may use the
struct net_device for phydev, do you know why so many drivers use
the private structure ?

If everybody agree, I can send a new version with a generic {get|set}_link_ksettings
and a update of fec to use the phydev store in the structure net_device.

Philippe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-07 01:20 +0200
  [PATCH 2/2] net: ethernet: fec: use ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-07 01:20 +0200
  Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-05-07 01:50 +0200
  Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Ben Hutchings <ben@decadent.org.uk> - 2016-05-07 14:10 +0200
    Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 01:00 +0200
      Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Ben Hutchings <ben@decadent.org.uk> - 2016-05-08 02:20 +0200
      Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-05-08 20:20 +0200

csiph-web