Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1396186

[PATCH 2/2] net: ethernet: fec: use ethtool_phy_{get|set}_link_ksettings

Show all headers | View raw

Use the generic ethtool_phy_{get|set}_link_ksettings to
generate the callback for {get|set}_link_ksettings.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
---
 drivers/net/ethernet/freescale/fec_main.c |   25 ++-----------------------
 1 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index bfa10c3..00339d0 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2058,29 +2058,8 @@ static void fec_enet_mii_remove(struct fec_enet_private *fep)
 	}
 }
 
-static int fec_enet_get_link_ksettings(struct net_device *ndev,
-				       struct ethtool_link_ksettings *cmd)
-{
-	struct fec_enet_private *fep = netdev_priv(ndev);
-	struct phy_device *phydev = fep->phy_dev;
-
-	if (!phydev)
-		return -ENODEV;
-
-	return phy_ethtool_ksettings_get(phydev, cmd);
-}
-
-static int fec_enet_set_link_ksettings(struct net_device *ndev,
-				       const struct ethtool_link_ksettings *cmd)
-{
-	struct fec_enet_private *fep = netdev_priv(ndev);
-	struct phy_device *phydev = fep->phy_dev;
-
-	if (!phydev)
-		return -ENODEV;
-
-	return phy_ethtool_ksettings_set(phydev, cmd);
-}
+ethtool_phy_get_link_ksettings(fec_enet, fec_enet_private, phy_dev);
+ethtool_phy_set_link_ksettings(fec_enet, fec_enet_private, phy_dev);
 
 static void fec_enet_get_drvinfo(struct net_device *ndev,
 				 struct ethtool_drvinfo *info)
-- 
1.7.4.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-07 01:20 +0200
  [PATCH 2/2] net: ethernet: fec: use ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-07 01:20 +0200
  Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-05-07 01:50 +0200
  Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Ben Hutchings <ben@decadent.org.uk> - 2016-05-07 14:10 +0200
    Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 01:00 +0200
      Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Ben Hutchings <ben@decadent.org.uk> - 2016-05-08 02:20 +0200
      Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-05-08 20:20 +0200

csiph-web