Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1396197

Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings

Show all headers | View raw

On 06/05/16 16:18, Philippe Reynes wrote:
> The callback {get|set}_link_ksettings are often defined
> in a very close way. There are mainly two differences in
> those callback:
> - the name of the netdev private structure
> - the name of the struct phydev in the private structure
> 
> We add two defines ethtool_phy_{get|set}_link_ksettings
> to avoid writing severals times almost the same function.

This looks fine in principle, but then there is a whole ton of code that
could become like that in the kernel, I do not have any strong opinion
either way...
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-07 01:20 +0200
  [PATCH 2/2] net: ethernet: fec: use ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-07 01:20 +0200
  Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-05-07 01:50 +0200
  Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Ben Hutchings <ben@decadent.org.uk> - 2016-05-07 14:10 +0200
    Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 01:00 +0200
      Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Ben Hutchings <ben@decadent.org.uk> - 2016-05-08 02:20 +0200
      Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-05-08 20:20 +0200

csiph-web